RUBY-3105 Do not raise errors when closing cursor (#2615)

Co-authored-by: Neil Shweky <[email protected]>

Author: comandeo-mongo

lib/mongo/cursor.rb

@@ -276,9 +276,6 @@ def closed?
     # the server.
     #
     # @return [ nil ] Always nil.
-    #
-    # @raise [ Error::OperationFailure ] If the server cursor close fails.
-    # @raise [ Error::SocketError | Error::SocketTimeoutError ] When there is a network error.
     def close
       return if closed?
 
@@ -294,6 +291,8 @@ def close
       end
 
       nil
+    rescue Error::OperationFailure, Error::SocketError, Error::SocketTimeoutError
+      # Errors are swallowed since there is noting can be done by handling them.
     ensure
       end_session
       @cursor_id = 0

spec/mongo/cursor_spec.rb

@@ -697,7 +697,11 @@
 
   describe '#close' do
     let(:view) do
-      Mongo::Collection::View.new(authorized_collection)
+      Mongo::Collection::View.new(
+        authorized_collection,
+        {},
+        batch_size: 2,
+      )
     end
 
     let(:server) do
@@ -712,25 +716,34 @@
       described_class.new(view, reply, server)
     end
 
+    let(:documents) do
+      (1..10).map{ |i| { field: "test#{i}" }}
+    end
+
+    before do
+      authorized_collection.drop
+      authorized_collection.insert_many(documents)
+    end
+
     it 'closes' do
+      expect(cursor).not_to be_closed
       cursor.close
       expect(cursor).to be_closed
     end
 
     context 'when there is a socket error during close' do
       clean_slate
 
-      before do
+      it 'does not raise an error' do
+        cursor
         server.with_connection do |conn|
           expect(conn).to receive(:deliver)
+            .at_least(:once)
             .and_raise(Mongo::Error::SocketError, "test error")
         end
-      end
-
-      it 'raises an error' do
         expect do
           cursor.close
-        end.to raise_error(Mongo::Error::SocketError, "test error")
+        end.not_to raise_error
       end
     end
   end