RUBY-1021 Tests for inspect methods

Author: estolfo

spec/mongo/client_spec.rb

@@ -203,6 +203,23 @@
         "<Mongo::Client:0x#{client.object_id} cluster=127.0.0.1:27017"
       )
     end
+
+    context 'when there is sensitive data in the options' do
+
+      let(:client) do
+        described_class.new(
+            ['127.0.0.1:27017'],
+            :read => { :mode => :primary },
+            :database => TEST_DB,
+            :password => '123',
+            :user => 'emily'
+        )
+      end
+
+      it 'does not print out sensitive data' do
+        expect(client.inspect).not_to match('123')
+      end
+    end
   end
 
   describe '#initialize' do
@@ -710,4 +727,19 @@
       expect(client.reconnect).to be(true)
     end
   end
+
+  describe '#dup' do
+
+    let(:client) do
+      described_class.new(
+          ['127.0.0.1:27017'],
+          :read => { :mode => :primary },
+          :database => TEST_DB
+      )
+    end
+
+    it 'creates a client with Redacted options' do
+      expect(client.dup.options).to be_a(Mongo::Options::Redacted)
+    end
+  end
 end

spec/mongo/server_selector/nearest_spec.rb

@@ -11,6 +11,7 @@
   end
 
   it_behaves_like 'a server selector accepting tag sets'
+  it_behaves_like 'a server selector with sensitive data in its options'
 
   describe '#to_mongos' do
 

spec/mongo/server_selector/primary_preferred_spec.rb

@@ -11,6 +11,7 @@
   end
 
   it_behaves_like 'a server selector accepting tag sets'
+  it_behaves_like 'a server selector with sensitive data in its options'
 
   describe '#to_mongos' do
 

spec/mongo/server_selector/primary_spec.rb

@@ -9,6 +9,7 @@
   it_behaves_like 'a server selector mode' do
     let(:slave_ok) { false }
   end
+  it_behaves_like 'a server selector with sensitive data in its options'
 
   describe '#tag_sets' do
 

spec/mongo/server_selector/secondary_preferred_spec.rb

@@ -9,6 +9,7 @@
   it_behaves_like 'a server selector mode' do
     let(:slave_ok) { true }
   end
+  it_behaves_like 'a server selector with sensitive data in its options'
 
   it_behaves_like 'a server selector accepting tag sets'
 

spec/mongo/server_selector/secondary_spec.rb

@@ -9,6 +9,7 @@
   it_behaves_like 'a server selector mode' do
     let(:slave_ok) { true }
   end
+  it_behaves_like 'a server selector with sensitive data in its options'
 
   it_behaves_like 'a server selector accepting tag sets'
 

spec/support/shared/server_selector.rb

@@ -32,7 +32,8 @@ def server(mode, options = {})
   end
   let(:primary) { server(:primary) }
   let(:secondary) { server(:secondary) }
-  let(:selector) { described_class.new(:mode => name, :tag_sets => tag_sets) }
+  let(:options) { { :mode => name, :tag_sets => tag_sets } }
+  let(:selector) { described_class.new(options) }
 
   before(:all) do
     module Mongo
@@ -157,3 +158,20 @@ class Server
     end
   end
 end
+
+shared_examples 'a server selector with sensitive data in its options' do
+
+  describe '#inspect' do
+
+    context 'when there is sensitive data in the options' do
+
+      let(:options) do
+        Mongo::Options::Redacted.new(:mode => name, :password => '123')
+      end
+
+      it 'does not print out sensitive data' do
+        expect(selector.inspect).not_to match(options[:password])
+      end
+    end
+  end
+end