Merge pull request #688 from mongodb/RUBY-1022

RUBY-1022/RUBY-1016: Don't fail queries with 'ok', 'err', or 'errmsg' fields in first doc.

Author: durran

lib/mongo/operation/read/query/result.rb

@@ -31,7 +31,7 @@ class Result < Operation::Result
           #
           # @since 2.0.0
           def successful?
-            !query_failure? && parser.message.empty?
+            !query_failure?
           end
         end
       end

spec/mongo/collection_spec.rb

@@ -470,6 +470,50 @@
       end
     end
 
+    context 'when the user is not authorized' do
+
+      let(:view) do
+        unauthorized_collection.find
+      end
+
+      it 'iterates over the documents' do
+        expect {
+          view.each{ |document| document }
+        }.to raise_error(Mongo::Error::OperationFailure)
+      end
+    end
+
+    context 'when documents contain potential error message fields' do
+
+      [ Mongo::Error::ERRMSG, Mongo::Error::ERROR, Mongo::Operation::Result::OK ].each do |field|
+
+        context "when the document contains a '#{field}' field" do
+
+          let(:value) do
+            'testing'
+          end
+
+          let(:view) do
+            authorized_collection.find
+          end
+
+          before do
+            authorized_collection.insert_one({ field => value })
+          end
+
+          after do
+            authorized_collection.delete_many
+          end
+
+          it 'iterates over the documents' do
+            view.each do |document|
+              expect(document[field]).to eq(value)
+            end
+          end
+        end
+      end
+    end
+
     context 'when provided options' do
 
       let(:view) do