Merge pull request #727 from estolfo/RUBY-1070-sdam-tests

RUBY-1070 Add missing SDAM test, make updates and adjust SDAM

Author: estolfo

lib/mongo/server/description.rb

@@ -364,7 +364,8 @@ def mongos?
       #
       # @since 2.0.0
       def other?
-        !primary? && !secondary? && !passive? && !arbiter?
+        (!primary? && !secondary? && !passive? && !arbiter?) ||
+          (hidden? && !replica_set_name.nil?)
       end
 
       # Will return true if the server is passive.

spec/support/sdam/rs/rsother_discovered.yml

@@ -7,12 +7,21 @@ phases: [
     {
         responses: [
 
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: false,
+                    secondary: true,
+                    hidden: true,
+                    hosts: ["c:27017", "d:27017"],
+                    setName: "rs"
+                }],
                 ["b:27017", {
 
                     ok: 1,
                     ismaster: false,
                     secondary: false,
-                    hosts: ["a:27017", "b:27017"],
+                    hosts: ["c:27017", "d:27017"],
                     setName: "rs"
                 }]
         ],
@@ -23,14 +32,26 @@ phases: [
 
                 "a:27017": {
 
-                    type: "Unknown",
-                    setName:
+                    type: "RSOther",
+                    setName: "rs"
                 },
 
                 "b:27017": {
 
                     type: "RSOther",
                     setName: "rs"
+                },
+
+                "c:27017": {
+
+                    type: "Unknown",
+                    setName: 
+                },
+
+                "d:27017": {
+
+                    type: "Unknown",
+                    setName: 
                 }
             },
 

spec/support/sdam/rs/stepdown_change_set_name.yml

@@ -0,0 +1,59 @@
+description: "Primary becomes a secondary with wrong setName"
+
+uri: "mongodb://a/?replicaSet=rs"
+
+phases: [
+
+    # Primary is discovered normally.
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: true,
+                    hosts: ["a:27017"],
+                    setName: "rs"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {
+
+                "a:27017": {
+
+                    type: "RSPrimary",
+                    setName: "rs"
+                }
+            },
+
+            topologyType: "ReplicaSetWithPrimary",
+            setName: "rs"
+        }
+    },
+
+    # Primary changes its setName and becomes secondary.
+    # Remove it and change the topologyType.
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: false,
+                    secondary: true,
+                    hosts: ["a:27017"],
+                    setName: "wrong"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {},
+
+            topologyType: "ReplicaSetNoPrimary",
+            setName: "rs"
+        }
+    }
+]