WIP

Author: gssbzn

Makefile

@@ -5,7 +5,7 @@ COVERAGE=coverage.out
 
 MCLI_SOURCE_FILES?=./cmd/mongocli
 MCLI_BINARY_NAME=mongocli
-MCLI_VERSION?=$(shell git tag --list 'mongocli/v*' --sort=committerdate | tail -1 | cut -d "v" -f 2 |  xargs -I % sh -c 'echo %-next' )
+MCLI_VERSION?=1.21.0 #$(shell git tag --list 'mongocli/v*' --sort=committerdate | tail -1 | cut -d "v" -f 2 |  xargs -I % sh -c 'echo %-next' )
 MCLI_GIT_SHA?=$(shell git rev-parse HEAD)
 MCLI_DESTINATION=./bin/$(MCLI_BINARY_NAME)
 MCLI_INSTALL_PATH="${GOPATH}/bin/$(MCLI_BINARY_NAME)"

internal/cli/root/mongocli/builder.go

@@ -16,9 +16,6 @@ package mongocli
 
 import (
 	"fmt"
-	"io"
-	"runtime"
-
 	"github.com/mongodb/mongocli/internal/cli"
 	"github.com/mongodb/mongocli/internal/cli/atlas"
 	"github.com/mongodb/mongocli/internal/cli/auth"
@@ -29,18 +26,24 @@ import (
 	"github.com/mongodb/mongocli/internal/cli/opsmanager"
 	"github.com/mongodb/mongocli/internal/config"
 	"github.com/mongodb/mongocli/internal/flag"
+	"github.com/mongodb/mongocli/internal/homebrew"
 	"github.com/mongodb/mongocli/internal/latestrelease"
 	"github.com/mongodb/mongocli/internal/search"
 	"github.com/mongodb/mongocli/internal/usage"
 	"github.com/mongodb/mongocli/internal/version"
+	"github.com/spf13/afero"
 	"github.com/spf13/cobra"
+	"io"
+	"runtime"
 )
 
+type Notifier struct {
+}
+
 // Builder conditionally adds children commands as needed.
 // This is important in particular for Atlas as it dynamically sets flags for cluster creation and
 // this can be slow to timeout on environments with limited internet access (Ops Manager).
 func Builder(profile *string, argsWithoutProg []string) *cobra.Command {
-
 	rootCmd := &cobra.Command{
 		Version: version.Version,
 		Use:     config.ToolName,
@@ -58,9 +61,15 @@ func Builder(profile *string, argsWithoutProg []string) *cobra.Command {
 			if shouldSkipPrintNewVersion(w) {
 				return
 			}
-			printer := latestrelease.NewPrinter(w, config.ToolName, config.BinName())
-			checker := latestrelease.NewChecker(version.Version, config.ToolName, printer)
+			c, _ := homebrew.NewChecker(afero.NewOsFs())
+			c.IsHomebrew()
+			// p := NewPrinter(w, config.ToolName, config.BinName(), c.IsHomebrew())
+			checker := latestrelease.NewChecker(version.Version, config.ToolName)
+			// shouldCheck && isLatests{
+			// print new vercions
+			//}
 			_ = checker.CheckAvailable()
+
 		},
 	}
 	rootCmd.SetVersionTemplate(formattedVersion())
@@ -107,6 +116,42 @@ func Builder(profile *string, argsWithoutProg []string) *cobra.Command {
 	return rootCmd
 }
 
+type Printer interface {
+	PrintNewVersionAvailable(latestVersion, homebrewCommand string) error
+}
+
+func NewPrinter(w io.Writer, t, b string) Printer {
+	return &printer{
+		writer: w,
+		tool:   t,
+		bin:    b,
+	}
+}
+
+type printer struct {
+	writer io.Writer
+	tool   string
+	bin    string
+}
+
+func (p *printer) PrintNewVersionAvailable(latestVersion, formulaName string) error {
+	var upgradeInstructions string
+	if formulaName != "" {
+		upgradeInstructions = fmt.Sprintf(`To upgrade, run "brew update && brew upgrade %s".`, formulaName)
+	} else {
+		upgradeInstructions = fmt.Sprintf(`To upgrade, see: https://dochub.mongodb.org/core/%s-install.`, p.tool)
+	}
+
+	newVersionTemplate := `
+A new version of %s is available '%s'!
+%s
+
+To disable this alert, run "%s config set skip_update_check true".
+`
+	_, err := fmt.Fprintf(p.writer, newVersionTemplate, p.tool, latestVersion, upgradeInstructions, p.bin)
+	return err
+}
+
 const verTemplate = `%s version: %s
 git version: %s
 Go version: %s

internal/homebrew/homebrew.go

@@ -0,0 +1,130 @@
+// Copyright 2022 MongoDB Inc
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package homebrew
+
+import (
+	"bytes"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"strings"
+	"time"
+
+	"github.com/mongodb/mongocli/internal/config"
+	"github.com/mongodb/mongocli/internal/file"
+	"github.com/spf13/afero"
+)
+
+//go:generate mockgen -destination=../mocks/mock_brew_store.go -package=mocks github.com/mongodb/mongocli/internal/homebrew PathStore
+
+const atlasFormulaName = "mongodb-atlas"
+
+// formulaName get homebrew suitable command for a given tool.
+func formulaName(tool string) string {
+	if strings.Contains(tool, "atlas") {
+		return atlasFormulaName
+	}
+	return tool
+}
+
+// IsHomebrew checks if the cli was installed with homebrew.
+func (s Checker) IsHomebrew() bool {
+	h, err := s.Load()
+	// If one of the values was not found previously it is still a valid case - rely on the file.
+	if (h.ExecutablePath != "" || h.FormulaPath != "") && err == nil {
+		return strings.HasPrefix(h.ExecutablePath, h.FormulaPath)
+	}
+	formula := formulaName(config.BinName())
+	buf := new(bytes.Buffer)
+	cmd := exec.Command("brew", "--prefix", "--installed", formula)
+
+	cmd.Stdout = buf
+	if err := cmd.Start(); err != nil {
+		return false
+	}
+
+	executablePath, err := executableCurrentPath()
+	if err != nil {
+		return false
+	}
+	h.ExecutablePath = executablePath
+
+	if err := cmd.Wait(); err != nil {
+		return false
+	}
+	brewFormulaPath, err := filepath.EvalSymlinks(strings.TrimSpace(buf.String()))
+	if err != nil {
+		return false
+	}
+	h.FormulaPath = brewFormulaPath
+	_ = s.Save(h)
+	return strings.HasPrefix(executablePath, brewFormulaPath)
+}
+
+func executableCurrentPath() (string, error) {
+	executablePath, err := os.Executable()
+	if err != nil {
+		return "", err
+	}
+	return filepath.EvalSymlinks(executablePath)
+}
+
+type homebrew struct {
+	CheckedAt      time.Time `yaml:"checked_at"`
+	ExecutablePath string    `yaml:"executable_path"`
+	FormulaPath    string    `yaml:"formula_path"`
+}
+
+type Loader interface {
+	Load() (*homebrew, error)
+}
+
+type LoaderSaver interface {
+	Loader
+	Save(*homebrew) error
+}
+
+func NewChecker(fileSystem afero.Fs) (*Checker, error) {
+	filePath, err := config.Path(brewFileSubPath)
+	if err != nil {
+		return nil, err
+	}
+	return &Checker{fs: fileSystem, path: filePath}, nil
+}
+
+type Checker struct {
+	path string
+	fs   afero.Fs
+}
+
+const brewFileSubPath = "/brew.yaml"
+
+// Load will load the latest calculated brew path.
+func (s *Checker) Load() (*homebrew, error) {
+	path := new(homebrew)
+	if err := file.Load(s.fs, s.path, path); err != nil {
+		return nil, err
+	}
+
+	if path != nil && time.Since(path.CheckedAt).Hours() < 24 {
+		return path, nil
+	}
+	return nil, nil
+}
+
+// Save will save the latest calculated brew path.
+func (s *Checker) Save(h *homebrew) error {
+	return file.Save(s.fs, s.path, h)
+}

internal/homebrew/loadersaver_test.go renamed to internal/homebrew/homebrew_test.go

@@ -18,6 +18,9 @@
 package homebrew
 
 import (
+	"fmt"
+	"github.com/golang/mock/gomock"
+	"github.com/mongodb/mongocli/internal/mocks"
 	"testing"
 
 	"github.com/mongodb/mongocli/internal/config"
@@ -86,3 +89,29 @@ func TestFile(t *testing.T) {
 		}
 	})
 }
+
+func TestOutputOpts_testIsHomebrew(t *testing.T) {
+	tests := []struct {
+		tool string
+		isHb bool
+	}{
+		{"atlascli", false},
+		{"mongocli", false},
+	}
+
+	for _, tt := range tests {
+		t.Run(fmt.Sprintf("%v_ishomebrew_%v", tt.tool, tt.isHb), func(t *testing.T) {
+			ctrl := gomock.NewController(t)
+			mockStore := mocks.NewMockPathStore(ctrl)
+			defer ctrl.Finish()
+
+			mockStore.EXPECT().LoadBrewPath().Return("", "", nil)
+			mockStore.EXPECT().SaveBrewPath(gomock.Any(), gomock.Any()).Return(nil)
+
+			result := IsHomebrew(mockStore)
+			if result != tt.isHb {
+				t.Errorf("got = %v, want %v", result, tt.isHb)
+			}
+		})
+	}
+}