CLOUDP-120923: [Atlas CLI] Telemetry - Add Feature Flag #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Apr 27, 2022
Comment on lines
+474
to
477
| func isTelemetryFeatureFlagSet() bool { | ||
| _, featureFlagSet := os.LookupEnv("MONGODB_ATLAS_TELEMETRY_FEATURE_FLAG") | ||
| return featureFlagSet | ||
| } |
There was a problem hiding this comment.
this is not how we do env vars, please use viper
There was a problem hiding this comment.
@johansteyn As this has already been merged, can you make a follow up ticket to do the cleanup? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-120923
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments
A very simple way to allow telemetry in atlascli only if an environment variable is set, eg:
% export MONGODB_ATLAS_TELEMETRY_FEATURE_FLAG=trueOnce development is complete and we are ready to roll out telemetry this will be removed (CLOUDP-121000)