Skip to content

CLOUDP-113791: [MongoCLI] Now that we are releasing both atlascli and mongocli we have to rename the archive.targz_pack #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Feb 25, 2022

Proposed changes

Jira ticket: CLOUDP-113791

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

[MongoCLI] Now that we are releasing both atlascli and mongocli we have to rename the archive.targz_pack from rpm.tgz to atlascli-rmp.tgx and mongocli-rpm.tgx

@andreaangiolillo andreaangiolillo marked this pull request as ready for review February 25, 2022 13:44
@andreaangiolillo andreaangiolillo requested a review from a team February 25, 2022 13:44
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scheduled the packaging tasks, LGTM if that passes and keep an eye on the publishing task once merge.

Also not sure if we should do it but it feels like we should split the packaging build variant into two, one for atlas and one for mongocli instead of two tasks in a generic build variant

Having different build variants should allow you to probably use the same tasks with different args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants