Fix backup compliance policy without onDemandPolicy (#2331)

This addresses a bug where the `onDemandPolicy` can be missing in the
CRD but is still uploaded to Atlas, creating an error.

Author: tvdw-mongodb

api/v1/atlasbackupcompliancepolicy_types.go

@@ -99,11 +99,14 @@ func (b *AtlasBackupCompliancePolicy) ToAtlas(projectID string) *admin.DataProte
 		RestoreWindowDays:       pointer.MakePtr(b.Spec.RestoreWindowDays),
 	}
 
-	result.OnDemandPolicyItem = &admin.BackupComplianceOnDemandPolicyItem{
-		FrequencyInterval: 0,
-		FrequencyType:     "ondemand",
-		RetentionValue:    b.Spec.OnDemandPolicy.RetentionValue,
-		RetentionUnit:     strings.ToLower(b.Spec.OnDemandPolicy.RetentionUnit),
+	var emptyPolicy AtlasOnDemandPolicy
+	if b.Spec.OnDemandPolicy != emptyPolicy {
+		result.OnDemandPolicyItem = &admin.BackupComplianceOnDemandPolicyItem{
+			FrequencyInterval: 0,
+			FrequencyType:     "ondemand",
+			RetentionValue:    b.Spec.OnDemandPolicy.RetentionValue,
+			RetentionUnit:     strings.ToLower(b.Spec.OnDemandPolicy.RetentionUnit),
+		}
 	}
 
 	temp := make([]admin.BackupComplianceScheduledPolicyItem, len(b.Spec.ScheduledPolicyItems))

api/v1/atlasbackupcompliancepolicy_types_test.go

@@ -144,8 +144,8 @@ func TestBackupCompliancePolicyFromAtlas(t *testing.T) {
 	})
 }
 
-func TestBackupCompliancePolicyNilOndemandPolicy(t *testing.T) {
-	t.Run("Can convert when OndemandPolicyItem is nil", func(t *testing.T) {
+func TestBackupCompliancePolicyFromAtlasNilOndemandPolicy(t *testing.T) {
+	t.Run("Can convert from Atlas when OndemandPolicyItem is nil", func(t *testing.T) {
 		in := &admin.DataProtectionSettings20231001{
 			AuthorizedEmail:         "[email protected]",
 			AuthorizedUserFirstName: "James",
@@ -190,3 +190,57 @@ func TestBackupCompliancePolicyNilOndemandPolicy(t *testing.T) {
 		assert.True(t, reflect.DeepEqual(*out, want), cmp.Diff(*out, want))
 	})
 }
+
+func TestBackupCompliancePolicyToAtlasNilOndemandPolicy(t *testing.T) {
+	t.Run("Can convert to Atlas when OndemandPolicyItem is nil", func(t *testing.T) {
+		in := AtlasBackupCompliancePolicy{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "my-bcp",
+				Namespace: "test-ns",
+				Labels: map[string]string{
+					"test": "label",
+				},
+			},
+			Spec: AtlasBackupCompliancePolicySpec{
+				AuthorizedEmail:         "[email protected]",
+				AuthorizedUserFirstName: "James",
+				AuthorizedUserLastName:  "Bond",
+				CopyProtectionEnabled:   true,
+				EncryptionAtRestEnabled: false,
+				PITEnabled:              true,
+				RestoreWindowDays:       24,
+				ScheduledPolicyItems: []AtlasBackupPolicyItem{
+					{
+						FrequencyType:     "monthly",
+						FrequencyInterval: 2,
+						RetentionUnit:     "months",
+						RetentionValue:    4,
+					},
+				},
+			},
+		}
+		out := in.ToAtlas("testProjectID")
+
+		want := admin.DataProtectionSettings20231001{
+			AuthorizedEmail:         "[email protected]",
+			AuthorizedUserFirstName: "James",
+			AuthorizedUserLastName:  "Bond",
+			CopyProtectionEnabled:   pointer.MakePtr(true),
+			EncryptionAtRestEnabled: pointer.MakePtr(false),
+			PitEnabled:              pointer.MakePtr(true),
+			ProjectId:               pointer.MakePtr("testProjectID"),
+			RestoreWindowDays:       pointer.MakePtr(24),
+			ScheduledPolicyItems: &[]admin.BackupComplianceScheduledPolicyItem{
+				{
+					FrequencyType:     "monthly",
+					FrequencyInterval: 2,
+					RetentionUnit:     "months",
+					RetentionValue:    4,
+				},
+			},
+			OnDemandPolicyItem: nil,
+		}
+
+		assert.True(t, reflect.DeepEqual(*out, want), cmp.Diff(*out, want))
+	})
+}