Reconcile fix (#2208)

Signed-off-by: jose.vazquez <[email protected]>

Author: josvazg

internal/translation/deployment/compare.go

@@ -314,7 +314,8 @@ func computeAutoscalingConfigAreEqual(desired, current *akov2.ComputeSpec) bool
 		return false
 	}
 
-	if desired.MinInstanceSize != current.MinInstanceSize {
+	scaleDown := current.ScaleDownEnabled != nil && *current.ScaleDownEnabled
+	if scaleDown && (desired.MinInstanceSize != current.MinInstanceSize) {
 		return false
 	}
 

internal/translation/deployment/compare_test.go

@@ -1779,14 +1779,27 @@ func TestComputeAutoscalingConfigAreEqual(t *testing.T) {
 				ScaleDownEnabled: pointer.MakePtr(false),
 			},
 		},
-		"should return false when min instance has changed": {
+		"should return false when min instance has changed and scale down is enabled": {
 			akoAutoscaling: &akov2.ComputeSpec{
-				MinInstanceSize: "M20",
+				ScaleDownEnabled: pointer.MakePtr(true),
+				MinInstanceSize:  "M20",
 			},
 			atlasAutoscaling: &akov2.ComputeSpec{
-				MinInstanceSize: "M10",
+				ScaleDownEnabled: pointer.MakePtr(true),
+				MinInstanceSize:  "M10",
 			},
 		},
+		"should return true when min instance has changed and scale down is disabled": {
+			akoAutoscaling: &akov2.ComputeSpec{
+				ScaleDownEnabled: pointer.MakePtr(false),
+				MinInstanceSize:  "M20",
+			},
+			atlasAutoscaling: &akov2.ComputeSpec{
+				ScaleDownEnabled: pointer.MakePtr(false),
+				MinInstanceSize:  "M10",
+			},
+			expected: true,
+		},
 		"should return false when max instance has changed": {
 			akoAutoscaling: &akov2.ComputeSpec{
 				MaxInstanceSize: "M20",