NODE-909 Ensure ensureIndex read is performed against PRIMARY server

Author: christkv

lib/db.js

@@ -1032,8 +1032,6 @@ Db.prototype.createIndex = function(name, fieldOrSpec, options, callback) {
   options = options == null ? {} : options;
   // Shallow clone the options
   options = shallowClone(options);
-  // Run only against primary
-  options.readPreference = ReadPreference.PRIMARY;
 
   // If we have a callback fallback
   if(typeof callback == 'function') return createIndex(self, name, fieldOrSpec, options, callback);
@@ -1048,12 +1046,15 @@ Db.prototype.createIndex = function(name, fieldOrSpec, options, callback) {
 
 var createIndex = function(self, name, fieldOrSpec, options, callback) {
   // Get the write concern options
-  var finalOptions = writeConcern({}, self, options);
+  var finalOptions = writeConcern({}, self, options, { readPreference: ReadPreference.PRIMARY });
   // Ensure we have a callback
   if(finalOptions.writeConcern && typeof callback != 'function') {
     throw MongoError.create({message: "Cannot use a writeConcern without a provided callback", driver:true});
   }
 
+  // Run only against primary
+  options.readPreference = ReadPreference.PRIMARY;
+
   // Did the user destroy the topology
   if(self.serverConfig && self.serverConfig.isDestroyed()) return callback(new MongoError('topology was destroyed'));
 
@@ -1136,6 +1137,9 @@ var ensureIndex = function(self, name, fieldOrSpec, options, callback) {
   // Did the user destroy the topology
   if(self.serverConfig && self.serverConfig.isDestroyed()) return callback(new MongoError('topology was destroyed'));
 
+  // Merge primary readPreference
+  finalOptions.readPreference = ReadPreference.PRIMARY
+
   // Check if the index allready exists
   self.indexInformation(name, finalOptions, function(err, indexInformation) {
     if(err != null && err.code != 26) return handleCallback(callback, err, null);
@@ -1645,7 +1649,6 @@ var indexInformation = function(self, name, options, callback) {
 
   // Did the user destroy the topology
   if(self.serverConfig && self.serverConfig.isDestroyed()) return callback(new MongoError('topology was destroyed'));
-
   // Process all the results from the index command and collection
   var processResults = function(indexes) {
     // Contains all the information
@@ -1664,7 +1667,7 @@ var indexInformation = function(self, name, options, callback) {
   }
 
   // Get the list of indexes of the specified collection
-  self.collection(name).listIndexes().toArray(function(err, indexes) {
+  self.collection(name).listIndexes(options).toArray(function(err, indexes) {
     if(err) return callback(toError(err));
     if(!Array.isArray(indexes)) return handleCallback(callback, null, []);
     if(full) return handleCallback(callback, null, indexes);

package.json

@@ -15,6 +15,7 @@
   "dependencies": {
     "es6-promise": "3.2.1",
     "mongodb-core": "2.1.6",
+    "mongodb-core": "christkv/mongodb-core#2.0",
     "readable-stream": "2.1.5"
   },
   "devDependencies": {

test/functional/authentication_tests.js

@@ -817,6 +817,72 @@ exports['Should correctly perform nearest read from secondaries without auth fai
   }
 }
 
+/**
+ * @ignore
+ */
+exports['Should correctly create indexes without hanging when different seedlists'] = {
+  metadata: { requires: { topology: ['auth'] } },
+
+  // The actual test we wish to run
+  test: function(configuration, test) {
+    var Db = configuration.require.Db
+      , Server = configuration.require.Server
+      , ReadPreference = configuration.require.ReadPreference
+      , MongoClient = configuration.require.MongoClient
+      , ReplSet = configuration.require.ReplSet;
+
+    setUp(configuration, function(err, replicasetManager) {
+      var replSet = new ReplSet( [
+          new Server( 'localhost', 31000),
+          new Server( 'localhost', 31001)
+        ],
+        {rs_name: 'rs', poolSize:1}
+      );
+
+      // Connect
+      new Db('replicaset_test_auth', replSet, {
+        w: 1, readPreference: ReadPreference.NEAREST
+      }).open(function(err, db) {
+        // Add a user
+        db.admin().addUser("root", "root", {w:3, wtimeout: 25000}, function(err, result) {
+          test.equal(null, err);
+
+          // process.exit(0)
+          db.close();
+
+          MongoClient.connect('mongodb://root:root@localhost:31000,localhost:31001,localhost:31002/admin?replicaSet=rs&readPreference=secondary', function(err, db) {
+            test.equal(null, err);
+
+            // Attempt create index
+            db.db('replicaset_test_auth')
+              .collection('createIndexes1')
+              .ensureIndex({ expiresAt: 1 }, { expireAfterSeconds: 0 }, function(err, r) {
+              test.equal(null, err);
+              db.close();
+
+              MongoClient.connect('mongodb://root:root@localhost:31002/admin?replicaSet=rs&readPreference=secondary', function(err, db) {
+                test.equal(null, err);
+
+                db.db('replicaset_test_auth')
+                  .collection('createIndexes2')
+                  .ensureIndex({ expiresAt: 1 }, { expireAfterSeconds: 0 }, function(err, r) {
+                    console.dir(err)
+                  test.equal(null, err);
+                  db.close();
+
+                  replicasetManager.stop().then(function() {
+                   test.done();
+                  });
+                });
+              });
+            });
+          });
+        });
+      });
+    })
+  }
+}
+
 /**
  * @ignore
  */