fix: skip

Author: nbbeeken

test/integration/auth/auth.prose.test.js

@@ -10,20 +10,10 @@ const semver = require('semver');
 const { TopologyType } = require('../../../src');
 
 describe('auth prose tests', () => {
-  beforeEach(async function () {
-    if (!semver.satisfies(this.configuration.version, '>=3.7.3')) {
-      this.currentTest.skipReason = 'Requires version >=3.7.3';
-      return this.skip();
-    }
-    if (this.configuration.topologyType === TopologyType.LoadBalanced) {
-      this.currentTest.skipReason = 'Requires non-loadbalanced topology';
-      return this.skip();
-    }
-  });
-
   describe('SCRAM-SHA-256 prose test', () => {
     describe('SCRAM-SHA-256 prose test Steps 1-3', function () {
-      const test = {};
+      let sandbox;
+      let oldDbName;
       const userMap = {
         sha1: {
           description: 'user with sha1 credentials',
@@ -51,18 +41,29 @@ describe('auth prose tests', () => {
 
       const users = Object.keys(userMap).map(name => userMap[name]);
 
-      afterEach(() => test.sandbox.restore());
+      afterEach(() => {
+        if (sandbox) sandbox.restore();
+      });
 
       /**
        * Step 1
        * Create three test users, one with only SHA-1, one with only SHA-256 and one with both.
        */
       beforeEach(async function () {
-        test.sandbox = sinon.createSandbox();
+        if (!semver.satisfies(this.configuration.version, '>=3.7.3')) {
+          this.currentTest.skipReason = 'Requires version >=3.7.3';
+          return this.skip();
+        }
+        if (this.configuration.topologyType === TopologyType.LoadBalanced) {
+          this.currentTest.skipReason = 'Requires non-loadbalanced topology';
+          return this.skip();
+        }
+
+        sandbox = sinon.createSandbox();
         await setupDatabase(this.configuration);
 
         const client = this.configuration.newClient();
-        test.oldDbName = this.configuration.db;
+        oldDbName = this.configuration.db;
         this.configuration.db = 'admin';
         const db = client.db(this.configuration.db);
 
@@ -80,7 +81,7 @@ describe('auth prose tests', () => {
       afterEach(async function () {
         const client = this.configuration.newClient();
         const db = client.db(this.configuration.db);
-        this.configuration.db = test.oldDbName;
+        this.configuration.db = oldDbName;
 
         await Promise.all(users.map(user => db.removeUser(user.username).catch(() => null)));
         await client.close();
@@ -167,7 +168,7 @@ describe('auth prose tests', () => {
           authSource: this.configuration.db
         };
 
-        test.sandbox.spy(ScramSHA256.prototype, 'auth');
+        sandbox.spy(ScramSHA256.prototype, 'auth');
 
         const client = this.configuration.newClient({}, options);
         await client.db().command({ ping: 1 });
@@ -188,19 +189,17 @@ describe('auth prose tests', () => {
           };
 
           let runCommandSpy;
-          test.sandbox
-            .stub(ScramSHA256.prototype, 'auth')
-            .callsFake(function (authContext, callback) {
-              const connection = authContext.connection;
-              const auth = ScramSHA256.prototype.auth.wrappedMethod;
-              runCommandSpy = test.sandbox.spy(connection, 'command');
-              function _callback(err, res) {
-                runCommandSpy.restore();
-                callback(err, res);
-              }
-
-              auth.apply(this, [authContext, _callback]);
-            });
+          sandbox.stub(ScramSHA256.prototype, 'auth').callsFake(function (authContext, callback) {
+            const connection = authContext.connection;
+            const auth = ScramSHA256.prototype.auth.wrappedMethod;
+            runCommandSpy = sandbox.spy(connection, 'command');
+            function _callback(err, res) {
+              runCommandSpy.restore();
+              callback(err, res);
+            }
+
+            auth.apply(this, [authContext, _callback]);
+          });
 
           const client = this.configuration.newClient({}, options);
           await client.db().command({ ping: 1 });
@@ -286,7 +285,7 @@ describe('auth prose tests', () => {
             authSource: this.configuration.db
           };
 
-          const commandSpy = test.sandbox.spy(Connection.prototype, 'command');
+          const commandSpy = sandbox.spy(Connection.prototype, 'command');
           const client = this.configuration.newClient({}, options);
           await client.db().command({ ping: 1 });
           const calls = commandSpy
@@ -334,6 +333,14 @@ describe('auth prose tests', () => {
       ];
 
       beforeEach(async function () {
+        if (!semver.satisfies(this.configuration.version, '>=3.7.3')) {
+          this.currentTest.skipReason = 'Requires version >=3.7.3';
+          return this.skip();
+        }
+        if (this.configuration.topologyType === TopologyType.LoadBalanced) {
+          this.currentTest.skipReason = 'Requires non-loadbalanced topology';
+          return this.skip();
+        }
         await setupDatabase(this.configuration);
 
         const client = this.configuration.newClient();