PR requested changes 0

Author: aditi-khare-mongoDB

test/unit/connection_string.test.ts

@@ -850,31 +850,37 @@ describe('Connection String', function () {
       sinon.restore();
     });
 
-    it('when option is `stderr`, it is accessible through mongoLogger.logDestination', function () {
-      const client = new MongoClient('mongodb://a/?mongodbLogPath=stderr', {
-        [loggerFeatureFlag]: true
+    context('when option is `stderr`', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const client = new MongoClient('mongodb://a/?mongodbLogPath=stderr', {
+          [loggerFeatureFlag]: true
+        });
+        const log: Log = { t: new Date(), c: 'ConnectionStringStdErr', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
       });
-      const log: Log = { t: new Date(), c: 'ConnectionStringStdErr', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
 
-    it('when option is `stdout`, it is accessible through mongoLogger.logDestination', function () {
-      const client = new MongoClient('mongodb://a/?mongodbLogPath=stdout', {
-        [loggerFeatureFlag]: true
+    context('when option is `stdout`', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const client = new MongoClient('mongodb://a/?mongodbLogPath=stdout', {
+          [loggerFeatureFlag]: true
+        });
+        const log: Log = { t: new Date(), c: 'ConnectionStringStdOut', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stdoutStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
       });
-      const log: Log = { t: new Date(), c: 'ConnectionStringStdOut', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stdoutStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
 
-    it('when option is invalid, it defaults to stderr', function () {
-      const client = new MongoClient('mongodb://a/?mongodbLogPath=stdnothing', {
-        [loggerFeatureFlag]: true
+    context('when option is invalid', function () {
+      it('it defaults to stderr', function () {
+        const client = new MongoClient('mongodb://a/?mongodbLogPath=stdnothing', {
+          [loggerFeatureFlag]: true
+        });
+        const log: Log = { t: new Date(), c: 'ConnectionStringInvalidOption', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
       });
-      const log: Log = { t: new Date(), c: 'ConnectionStringInvalidOption', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
   });
 });

test/unit/mongo_client.test.js

@@ -831,44 +831,68 @@ describe('MongoOptions', function () {
       sinon.restore();
     });
 
-    it('when option is `stderr`, it is accessible through mongoLogger.logDestination', function () {
-      const client = new MongoClient('mongodb://a/', {
-        [loggerFeatureFlag]: true,
-        mongodbLogPath: 'stderr'
+    context('when option is `stderr`', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const client = new MongoClient('mongodb://a/', {
+          [loggerFeatureFlag]: true,
+          mongodbLogPath: 'stderr'
+        });
+        const log = { t: new Date(), c: 'constructorStdErr', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
+      });
+    });
+
+    context('when option is a Writable stream', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const writable = new Writable();
+        const client = new MongoClient('mongodb://a/', {
+          [loggerFeatureFlag]: true,
+          mongodbLogPath: writable
+        });
+        expect(client.options.mongoLoggerOptions.logDestination).to.deep.equal(writable);
       });
-      const log = { t: new Date(), c: 'constructorStdErr', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
 
-    it('when option is a Writable stream, it is accessible through mongoLogger.logDestination', function () {
-      const writable = new Writable();
-      const client = new MongoClient('mongodb://a/', {
-        [loggerFeatureFlag]: true,
-        mongodbLogPath: writable
+    context('when option is a MongoDBLogWritable stream', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const writable = {
+          buffer: [],
+          write(log) {
+            this.buffer.push(log);
+          }
+        };
+        const client = new MongoClient('mongodb://a/', {
+          [loggerFeatureFlag]: true,
+          mongodbLogPath: writable
+        });
+        expect(client.options.mongoLoggerOptions.logDestination).to.deep.equal(writable);
       });
-      expect(client.options.mongoLoggerOptions.logDestination).to.deep.equal(writable);
     });
 
-    it('when option is `stdout`, it is accessible through mongoLogger.logDestination', function () {
-      const client = new MongoClient('mongodb://a/', {
-        [loggerFeatureFlag]: true,
-        mongodbLogPath: 'stdout'
+    context('when option is `stdout`', function () {
+      it('it is accessible through mongoLogger.logDestination', function () {
+        const client = new MongoClient('mongodb://a/', {
+          [loggerFeatureFlag]: true,
+          mongodbLogPath: 'stdout'
+        });
+        const log = { t: new Date(), c: 'constructorStdOut', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stdoutStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
       });
-      const log = { t: new Date(), c: 'constructorStdOut', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stdoutStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
 
-    it('when option is invalid, it defaults to stderr', function () {
-      const invalidOption = 'stdnothing';
-      const client = new MongoClient('mongodb://a/', {
-        [loggerFeatureFlag]: true,
-        mongodbLogPath: invalidOption
+    context('when option is invalid', function () {
+      it('it defaults to stderr', function () {
+        const invalidOption = 'stdnothing';
+        const client = new MongoClient('mongodb://a/', {
+          [loggerFeatureFlag]: true,
+          mongodbLogPath: invalidOption
+        });
+        const log = { t: new Date(), c: 'constructorInvalidOption', s: 'error' };
+        client.options.mongoLoggerOptions.logDestination.write(log);
+        expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
       });
-      const log = { t: new Date(), c: 'constructorInvalidOption', s: 'error' };
-      client.options.mongoLoggerOptions.logDestination.write(log);
-      expect(stderrStub.write).calledWith(inspect(log, { breakLength: Infinity, compact: true }));
     });
   });
 });