misc fixes

Author: baileympearson

src/collection.ts

@@ -683,13 +683,11 @@ export class Collection<TSchema extends Document = Document> {
     options?: IndexInformationOptions
   ): Promise<boolean> {
     const indexNames: string[] = [indexes].flat();
-    const allIndexes: Set<string> = new Set(
-      await this.listIndexes(options)
-        .map(({ name }) => name)
-        .toArray()
-    );
+    const allIndexes: string[] = await this.listIndexes(options)
+      .map(({ name }) => name)
+      .toArray();
 
-    return indexNames.every(name => allIndexes.has(name));
+    return indexNames.every(name => allIndexes.includes(name));
   }
 
   /**
@@ -804,7 +802,7 @@ export class Collection<TSchema extends Document = Document> {
    */
   async indexes(options?: IndexInformationOptions): Promise<Document[]> {
     const indexes = await this.listIndexes(options).toArray();
-    const full = options?.full ?? true === true;
+    const full = options?.full ?? true;
     if (full) {
       return indexes;
     }

test/integration/index_management.test.ts

@@ -286,14 +286,10 @@ describe('Indexes', function () {
   });
 
   context('when dropIndexes fails', function () {
-    let collection;
-
     beforeEach(async function () {
-      collection = await db.createCollection('test_drop_indexes');
-      await collection.insert({ a: 1 });
+      await collection.insertOne({ a: 1 });
       // Create an index on the collection
-      await db.createIndex(collection.collectionName, 'a');
-      /**@type {import('../tools/utils').FailPoint} */
+      await collection.createIndex('a');
       await client
         .db()
         .admin()
@@ -309,22 +305,18 @@ describe('Indexes', function () {
         });
     });
 
-    afterEach(async function () {
-      await db.dropCollection('test_drop_indexes');
-    });
-
-    it('should return false', {
-      metadata: {
+    it(
+      'should return false',
+      {
         requires: {
           mongodb: '>4.0'
         }
       },
-
-      test: async function () {
+      async function () {
         const result = await collection.dropIndexes();
         expect(result).to.equal(false);
       }
-    });
+    );
   });
 
   context('indexExists', function () {