implement tests

Author: baileympearson

test/integration/gridfs/gridfs.spec.test.js

@@ -0,0 +1,8 @@
+import { loadSpecTests } from '../../spec';
+import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
+
+describe('GridFS Unified Tests', function () {
+  runUnifiedSuite(loadSpecTests('gridfs'), ({ description }) => {
+    return description === 'download when final chunk is missing' ? `TODO(NODE-xxxx)` : false;
+  });
+});

test/integration/gridfs/gridfs.spec.test.ts

@@ -1,6 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-import { once, Writable } from 'node:stream';
+
+import { once, Readable, Writable } from 'node:stream';
+import { pipeline } from 'node:stream/promises';
 
 import { AssertionError, expect } from 'chai';
 
@@ -519,27 +520,28 @@ operations.set('delete', async ({ entities, operation }) => {
 operations.set('download', async ({ entities, operation }) => {
   const bucket = entities.getEntity('bucket', operation.object);
 
-  const stream = bucket.openDownloadStream(operation.arguments!.id);
-  return new Promise((resolve, reject) => {
-    const chunks: any[] = [];
-    stream.on('data', chunk => chunks.push(...chunk));
-    stream.on('error', reject);
-    stream.on('end', () => resolve(chunks));
-  });
+  const { id, ...options } = operation.arguments ?? {};
+  const stream = bucket.openDownloadStream(id, options);
+  return Buffer.concat(await stream.toArray());
 });
 
-operations.set('upload', async ({ entities, operation }) => {
+operations.set('downloadByName', async ({ entities, operation }) => {
   const bucket = entities.getEntity('bucket', operation.object);
 
-  const stream = bucket.openUploadStream(operation.arguments!.filename, {
-    chunkSizeBytes: operation.arguments?.chunkSizeBytes
-  });
+  const { filename, ...options } = operation.arguments ?? {};
+  const stream: Readable = bucket.openDownloadStreamByName(filename, options);
+
+  return Buffer.concat(await stream.toArray());
+});
+
+operations.set('upload', async ({ entities, operation }) => {
+  const bucket = entities.getEntity('bucket', operation.object);
+  const { filename, source, ...options } = operation.arguments ?? {};
 
-  const data = Buffer.from(operation.arguments!.source.$$hexBytes, 'hex');
-  const willFinish = once(stream, 'finish');
-  stream.end(data);
-  await willFinish;
+  const stream = bucket.openUploadStream(operation.arguments!.filename, options);
+  const filestream = Readable.from(Buffer.from(operation.arguments!.source.$$hexBytes, 'hex'));
 
+  await pipeline(filestream, stream);
   return stream.gridFSFile?._id;
 });