remove extraneous async logic

Author: W-A-James

src/cmap/connection_pool.ts

@@ -500,13 +500,7 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
   }
 
   /** Close the pool */
-  close(_options?: CloseOptions): void {
-    let options = _options as CloseOptions;
-    if (typeof options === 'function') {
-      options = {};
-    }
-
-    options = Object.assign({ force: false }, options);
+  close(): void {
     if (this.closed) {
       return;
     }
@@ -583,7 +577,7 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
       new ConnectionClosedEvent(this, connection, reason)
     );
     // destroy the connection
-    process.nextTick(() => connection.destroy());
+    connection.destroy();
   }
 
   private connectionIsStale(connection: Connection) {

src/sdam/server.ts

@@ -1,6 +1,6 @@
 import type { Document } from '../bson';
 import { type AutoEncrypter } from '../client-side-encryption/auto_encrypter';
-import { type CommandOptions, Connection, type DestroyOptions } from '../cmap/connection';
+import { type CommandOptions, Connection } from '../cmap/connection';
 import {
   ConnectionPool,
   type ConnectionPoolEvents,
@@ -235,9 +235,7 @@ export class Server extends TypedEventEmitter<ServerEvents> {
   }
 
   /** Destroy the server connection */
-  destroy(options?: DestroyOptions): void {
-    options = Object.assign({}, { force: false }, options);
-
+  destroy(): void {
     if (this.s.state === STATE_CLOSED) {
       return;
     }
@@ -248,7 +246,7 @@ export class Server extends TypedEventEmitter<ServerEvents> {
       this.monitor?.close();
     }
 
-    this.pool.close(options);
+    this.pool.close();
     stateTransition(this, STATE_CLOSED);
     this.emit('closed');
   }

src/sdam/topology.ts

@@ -2,8 +2,8 @@ import { promisify } from 'util';
 
 import type { BSONSerializeOptions, Document } from '../bson';
 import type { MongoCredentials } from '../cmap/auth/mongo_credentials';
-import type { ConnectionEvents, DestroyOptions } from '../cmap/connection';
-import type { CloseOptions, ConnectionPoolEvents } from '../cmap/connection_pool';
+import type { ConnectionEvents } from '../cmap/connection';
+import type { ConnectionPoolEvents } from '../cmap/connection_pool';
 import type { ClientMetadata } from '../cmap/handshake/client_metadata';
 import { DEFAULT_OPTIONS, FEATURE_FLAGS } from '../connection_string';
 import {
@@ -468,7 +468,8 @@ export class Topology extends TypedEventEmitter<TopologyEvents> {
       selectServerOptions,
       (err, server) => {
         if (err) {
-          return this.close({ force: false }, () => exitWithError(err));
+          this.close();
+          exitWithError(err);
         }
 
         const skipPingOnConnect = this.s.options[Symbol.for('@@mdb.skipPingOnConnect')] === true;
@@ -494,15 +495,13 @@ export class Topology extends TypedEventEmitter<TopologyEvents> {
   }
 
   /** Close this topology */
-  close(options?: CloseOptions): void {
-    options = options ?? { force: false };
-
+  close(): void {
     if (this.s.state === STATE_CLOSED || this.s.state === STATE_CLOSING) {
       return;
     }
 
     for (const server of this.s.servers.values()) {
-      destroyServer(server, this, { force: !!options?.force });
+      destroyServer(server, this);
     }
 
     this.s.servers.clear();
@@ -766,30 +765,20 @@ export class Topology extends TypedEventEmitter<TopologyEvents> {
 }
 
 /** Destroys a server, and removes all event listeners from the instance */
-function destroyServer(
-  server: Server,
-  topology: Topology,
-  options?: DestroyOptions,
-  callback?: Callback
-) {
-  options = options ?? { force: false };
+function destroyServer(server: Server, topology: Topology) {
   for (const event of LOCAL_SERVER_EVENTS) {
     server.removeAllListeners(event);
   }
 
-  server.destroy(options, () => {
-    topology.emitAndLog(
-      Topology.SERVER_CLOSED,
-      new ServerClosedEvent(topology.s.id, server.description.address)
-    );
+  server.destroy();
+  topology.emitAndLog(
+    Topology.SERVER_CLOSED,
+    new ServerClosedEvent(topology.s.id, server.description.address)
+  );
 
-    for (const event of SERVER_RELAY_EVENTS) {
-      server.removeAllListeners(event);
-    }
-    if (typeof callback === 'function') {
-      callback();
-    }
-  });
+  for (const event of SERVER_RELAY_EVENTS) {
+    server.removeAllListeners(event);
+  }
 }
 
 /** Predicts the TopologyType from options */