bug fixes for mapReduce and inheriting with transactions

Author: HanaPearlman

src/collection.ts

@@ -312,7 +312,7 @@ export class Collection implements OperationParent {
     callback?: Callback<InsertManyResult>
   ): Promise<InsertManyResult> | void {
     if (typeof options === 'function') (callback = options), (options = {});
-    options = resolveInheritedOptions(this, options ?? { ordered: true });
+    options = options || {};
 
     return executeOperation(
       getTopology(this),

src/operations/map_reduce.ts

@@ -17,6 +17,7 @@ import type { ObjectId } from '../bson';
 
 const exclusionList = [
   'readPreference',
+  'readConcern',
   'session',
   'bypassDocumentValidation',
   'w',

src/read_preference.ts

@@ -141,7 +141,8 @@ export class ReadPreference {
    */
   static fromOptions(options?: ReadPreferenceFromOptions): ReadPreference | undefined {
     if (!options) return;
-    const readPreference = options.readPreference;
+    const readPreference =
+      options.readPreference ?? options.session?.transaction.options.readPreference;
     const readPreferenceTags = options.readPreferenceTags;
 
     if (readPreference == null) {

src/utils.ts

@@ -1087,12 +1087,9 @@ function resolveWriteConcern(
   options: any
 ): WriteConcern | undefined {
   const session = options.session;
-  if (
-    session &&
-    session.inTransaction() &&
-    session.transaction.options.writeConcern !== 'undefined'
-  ) {
-    return session.transaction.options.writeConcern;
+  if (session && session.inTransaction()) {
+    // Users cannot pass a writeConcern to operations in a transaction
+    return;
   }
   return WriteConcern.fromOptions(options) || parent?.writeConcern;
 }
@@ -1102,12 +1099,9 @@ function resolveReadConcern(
   options: any
 ): ReadConcern | undefined {
   const session = options.session;
-  if (
-    session &&
-    session.inTransaction() &&
-    session.transaction.options.readConcern !== 'undefined'
-  ) {
-    return session.transaction.options.readConcern;
+  if (session && session.inTransaction()) {
+    // Users cannot pass a readConcern to operations in a transaction
+    return;
   }
   return ReadConcern.fromOptions(options) || parent?.readConcern;
 }
@@ -1116,15 +1110,7 @@ function resolveReadPreference(
   parent: OperationParent | undefined,
   options: any
 ): ReadPreference | undefined {
-  const session = options.session;
-  if (
-    session &&
-    session.inTransaction() &&
-    session.transaction.options.readPreference !== 'undefined'
-  ) {
-    return session.transaction.options.readPreference;
-  }
-  return ReadPreference.fromOptions(options) || parent?.readPreference;
+  return ReadPreference.fromOptions(options) ?? parent?.readPreference;
 }
 
 /** @internal Prioritizes options from transaction, then from options, then from parent */