capture the delebrate value of directConnection and use it for deciding to use sharded topology

Thomas Reggi · Thomas Reggi · commit 869b18797431 · 2020-09-30T13:34:46.000-04:00
diff --git a/lib/core/sdam/topology_description.js b/lib/core/sdam/topology_description.js
@@ -151,7 +151,7 @@ class TopologyDescription {
     // update the actual server description
     serverDescriptions.set(address, serverDescription);
 
-    if (serverType === ServerType.Mongos && this.s.options.directConnection === false) {
+    if (serverType === ServerType.Mongos && this.options._directConnection === false) {
       return new TopologyDescription(
         TopologyType.Sharded,
         serverDescriptions,
diff --git a/lib/core/uri_parser.js b/lib/core/uri_parser.js
@@ -687,6 +687,8 @@ function parseConnectionString(uri, options, callback) {
     return callback(new MongoParseError('directConnection option requires exactly one host'));
   }
 
+  parsedOptions._directConnection = Boolean(parsedOptions.directConnection);
+
   // NOTE: this behavior will go away in v4.0, we will always auto discover there
   if (
     parsedOptions.directConnection == null &&

Original file line number	Diff line number	Diff line change
`@@ -687,6 +687,8 @@ function parseConnectionString(uri, options, callback) {`
`687`	`687`	`return callback(new MongoParseError('directConnection option requires exactly one host'));`
`688`	`688`	`}`
`689`	`689`
	`690`	`+ parsedOptions._directConnection = Boolean(parsedOptions.directConnection);`
	`691`	`+`
`690`	`692`	`// NOTE: this behavior will go away in v4.0, we will always auto discover there`
`691`	`693`	`if (`
`692`	`694`	`parsedOptions.directConnection == null &&`