chore: fix required for getNumber

Author: nbbeeken

src/cmap/wire_protocol/on_demand/document.ts

@@ -261,7 +261,11 @@ export class OnDemandDocument {
       return this.bson[offset] ? 1 : 0;
     }
 
-    return null;
+    if (required === true) {
+      throw new BSONError(`BSON element "${name}" does not have numeric type: ${type}`);
+    } else {
+      return null;
+    }
   }
 
   /**

test/unit/cmap/wire_protocol/on_demand/document.test.ts

@@ -185,7 +185,8 @@ describe('class OnDemandDocument', () => {
       int: 1,
       long: 2n,
       double: 2.3,
-      bool: false
+      bool: false,
+      string: 'abc'
     };
 
     beforeEach(async function () {
@@ -202,6 +203,25 @@ describe('class OnDemandDocument', () => {
       expect(() => document.getNumber('blah!', true)).to.throw(BSONError);
     });
 
+    it('throws if required is set to true and element is not numeric', () => {
+      // just making sure this test does not fail for the non-exist reason
+      expect(document.hasElement('string')).to.be.true;
+      expect(() => document.getNumber('string', true)).to.throw(BSONError);
+    });
+
+    it('returns null if required is set to false and element does not exist', () => {
+      expect(document.getNumber('blah!', false)).to.be.null;
+      expect(document.getNumber('blah!')).to.be.null;
+    });
+
+    it('returns null if required is set to false and element is not numeric', () => {
+      // just making sure this test does not fail for the non-exist reason
+      expect(document.hasElement('string')).to.be.true;
+
+      expect(document.getNumber('string', false)).to.be.null;
+      expect(document.getNumber('string')).to.be.null;
+    });
+
     it('supports parsing int', () => {
       expect(document.getNumber('int')).to.equal(1);
     });