consistent intentional ignore error handlers

Author: nbbeeken

src/change_stream.ts

@@ -894,10 +894,7 @@ export class ChangeStream<
 
     if (isResumableError(changeStreamError, this.cursor.maxWireVersion)) {
       this._endStream();
-      this.cursor.close().then(
-        () => null,
-        () => null
-      ); // Ignoring the result of close is intentional
+      this.cursor.close().catch(() => null);
 
       const topology = getTopology(this.parent);
       topology.selectServer(this.cursor.readPreference, {}, serverSelectionError => {
@@ -927,10 +924,7 @@ export class ChangeStream<
     }
 
     if (isResumableError(changeStreamError, this.cursor.maxWireVersion)) {
-      this.cursor.close().then(
-        () => null,
-        () => null
-      ); // Ignoring the result of close is intentional
+      this.cursor.close().catch(() => null);
 
       const topology = getTopology(this.parent);
       topology.selectServer(this.cursor.readPreference, {}, serverSelectionError => {

src/cursor/abstract_cursor.ts

@@ -597,7 +597,7 @@ export abstract class AbstractCursor<
       // We only want to end this session if we created it, and it hasn't ended yet
       if (session.explicit === false) {
         if (!session.hasEnded) {
-          session.endSession(() => null);
+          session.endSession().catch(() => null);
         }
         this[kSession] = this.client.startSession({ owner: this, explicit: false });
       }
@@ -883,10 +883,7 @@ class ReadableCursorStream extends Readable {
         //       a client during iteration. Alternatively, we could do the "right" thing and
         //       propagate the error message by removing this special case.
         if (err.message.match(/server is closed/)) {
-          this._cursor.close().then(
-            () => null,
-            () => null
-          ); // Ignoring the result of close is intentional
+          this._cursor.close().catch(() => null);
           return this.push(null);
         }
 
@@ -905,10 +902,7 @@ class ReadableCursorStream extends Readable {
       if (result == null) {
         this.push(null);
       } else if (this.destroyed) {
-        this._cursor.close().then(
-          () => null,
-          () => null
-        ); // Ignoring the result of close is intentional
+        this._cursor.close().catch(() => null);
       } else {
         if (this.push(result)) {
           return this._readNext();

src/mongo_client.ts

@@ -493,7 +493,6 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> {
               { endSessions },
               { readPreference: ReadPreference.primaryPreferred, noResponse: true }
             )
-            .then(() => null) // outcome does not matter
             .catch(() => null); // outcome does not matter
         })
         .then(() => {
@@ -639,10 +638,7 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> {
         // Do not return the result of callback
       })
       .finally(() => {
-        session.endSession().then(
-          () => null,
-          () => null
-        );
+        session.endSession().catch(() => null);
       });
   }
 

src/operations/execute_operation.ts

@@ -144,10 +144,7 @@ export function executeOperation<
       });
     } catch (error) {
       if (session?.owner != null && session.owner === owner) {
-        session.endSession().then(
-          () => null,
-          () => null
-        ); // Ignoring the result of endSession is intentional
+        session.endSession().catch(() => null);
       }
 
       throw error;

src/sessions.ts

@@ -616,10 +616,7 @@ function attemptTransaction<TSchema>(
   }
 
   if (!isPromiseLike(promise)) {
-    session.abortTransaction().then(
-      () => null,
-      () => null
-    ); // TODO(NODE-XXXX): is this correct?
+    session.abortTransaction().catch(() => null);
     throw new MongoInvalidArgumentError(
       'Function provided to `withTransaction` must return a Promise'
     );