PoC commit 2 - fix failing test

aditi-khare-mongoDB · aditi-khare-mongoDB · commit ccc00946242c · 2024-03-25T17:25:03.000-04:00
diff --git a/src/sessions.ts b/src/sessions.ts
@@ -559,11 +559,11 @@ async function attemptTransactionCommit<T>(
       !isMaxTimeMSExpiredError(err)
     ) {
       if (err.hasErrorLabel(MongoErrorLabel.UnknownTransactionCommitResult)) {
-        return attemptTransactionCommit(session, startTime, fn, result, options);
+        return await attemptTransactionCommit(session, startTime, fn, result, options);
       }
 
       if (err.hasErrorLabel(MongoErrorLabel.TransientTransactionError)) {
-        return attemptTransaction(session, startTime, fn, options);
+        return await attemptTransaction(session, startTime, fn, options);
       }
     }
 
@@ -660,6 +660,7 @@ async function endTransaction(
     if (txnState === TxnState.STARTING_TRANSACTION) {
       // the transaction was never started, we can safely exit here
       session.transaction.transition(TxnState.TRANSACTION_ABORTED);
+      return;
     }
 
     if (txnState === TxnState.TRANSACTION_ABORTED) {

Original file line number	Diff line number	Diff line change
`@@ -559,11 +559,11 @@ async function attemptTransactionCommit<T>(`
`559`	`559`	`!isMaxTimeMSExpiredError(err)`
`560`	`560`	`) {`
`561`	`561`	`if (err.hasErrorLabel(MongoErrorLabel.UnknownTransactionCommitResult)) {`
`562`		`- return attemptTransactionCommit(session, startTime, fn, result, options);`
	`562`	`+ return await attemptTransactionCommit(session, startTime, fn, result, options);`
`563`	`563`	`}`
`564`	`564`
`565`	`565`	`if (err.hasErrorLabel(MongoErrorLabel.TransientTransactionError)) {`
`566`		`- return attemptTransaction(session, startTime, fn, options);`
	`566`	`+ return await attemptTransaction(session, startTime, fn, options);`
`567`	`567`	`}`
`568`	`568`	`}`
`569`	`569`
`@@ -660,6 +660,7 @@ async function endTransaction(`
`660`	`660`	`if (txnState === TxnState.STARTING_TRANSACTION) {`
`661`	`661`	`// the transaction was never started, we can safely exit here`
`662`	`662`	`session.transaction.transition(TxnState.TRANSACTION_ABORTED);`
	`663`	`+ return;`
`663`	`664`	`}`
`664`	`665`
`665`	`666`	`if (txnState === TxnState.TRANSACTION_ABORTED) {`