added tags for promoteValues/promoteLong/raw to find/findOne and aggregate

Author: christkv

lib/collection.js

@@ -1361,13 +1361,14 @@ define.classMethod('save', {callback: true, promise:true});
  * @param {number} [options.max=null] Set index bounds.
  * @param {boolean} [options.showDiskLoc=false] Show disk location of results.
  * @param {string} [options.comment=null] You can put a $comment field on a query to make looking in the profiler logs simpler.
- * @param {boolean} [options.raw=false] Return all BSON documents as Raw Buffer documents.
+ * @param {boolean} [options.raw=false] Return document results as raw BSON buffers.
+ * @param {boolean} [options.promoteLongs=true] Promotes Long values to number if they fit inside the 53 bits resolution.
+ * @param {boolean} [options.promoteValues=true] Promotes BSON values to native types where possible, set to false to only receive wrapper types.
  * @param {(ReadPreference|string)} [options.readPreference=null] The preferred read preference (ReadPreference.PRIMARY, ReadPreference.PRIMARY_PREFERRED, ReadPreference.SECONDARY, ReadPreference.SECONDARY_PREFERRED, ReadPreference.NEAREST).
  * @param {boolean} [options.partial=false] Specify if the cursor should return partial results when querying against a sharded system
  * @param {number} [options.maxTimeMS=null] Number of miliseconds to wait before aborting the query.
  * @param {Collection~resultCallback} [callback] The command result callback
  * @return {Promise} returns Promise if no callback passed
- * @deprecated use find().limit(1).next(function(err, doc){})
  */
 Collection.prototype.findOne = function() {
   var self = this;
@@ -2554,6 +2555,9 @@ function decorateWithCollation(command, self, options) {
  * @param {boolean} [options.allowDiskUse=false] allowDiskUse lets the server know if it can use disk to store temporary results for the aggregation (requires mongodb 2.6 >).
  * @param {number} [options.maxTimeMS=null] maxTimeMS specifies a cumulative time limit in milliseconds for processing operations on the cursor. MongoDB interrupts the operation at the earliest following interrupt point.
  * @param {boolean} [options.bypassDocumentValidation=false] Allow driver to bypass schema validation in MongoDB 3.2 or higher.
+ * @param {boolean} [options.raw=false] Return document results as raw BSON buffers.
+ * @param {boolean} [options.promoteLongs=true] Promotes Long values to number if they fit inside the 53 bits resolution.
+ * @param {boolean} [options.promoteValues=true] Promotes BSON values to native types where possible, set to false to only receive wrapper types.
  * @param {Collection~resultCallback} callback The command result callback
  * @return {(null|AggregationCursor)}
  */

test/functional/promote_values_tests.js

@@ -147,3 +147,40 @@ exports['should correctly honor promoteValues at cursor find level'] = {
     });
   }
 }
+
+exports['should correctly honor promoteValues at aggregate level'] = {
+  // Add a tag that our runner can trigger on
+  // in this case we are setting that node needs to be higher than 0.10.X to run
+  metadata: { requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] } },
+
+  // The actual test we wish to run
+  test: function(configuration, test) {
+    var Long = configuration.require.Long,
+      Int32 = configuration.require.Int32,
+      Double = configuration.require.Double,
+      MongoClient = configuration.require.MongoClient;
+
+    MongoClient.connect(configuration.url(), {
+    }, function(err, db) {
+      db.collection('shouldCorrectlyHonorPromoteValues2').insert({
+            doc: Long.fromNumber(10)
+          , int: 10
+          , double: 2.2222
+          , array: [[Long.fromNumber(10)]]
+        }, function(err, doc) {
+          test.equal(null, err);
+
+          db.collection('shouldCorrectlyHonorPromoteValues2').aggregate([{$match: {}}], {promoteValues: false}).next(function(err, doc) {
+            test.equal(null, err);
+
+            test.deepEqual(Long.fromNumber(10), doc.doc);
+            test.deepEqual(new Int32(10), doc.int);
+            test.deepEqual(new Double(2.2222), doc.double);
+
+            db.close();
+            test.done();
+          });
+      });
+    });
+  }
+}