chore: address comments on PR

- fix lint error
- update type to return false instead of null when tests should be run

Author: baileympearson

test/integration/collection-management/collection_management.spec.test.js

@@ -8,6 +8,6 @@ const SKIPPED_TESTS = ['modifyCollection to changeStreamPreAndPostImages enabled
 
 describe('Collection management unified spec tests', function () {
   runUnifiedSuite(loadSpecTests('collection-management'), ({ description }) =>
-    SKIPPED_TESTS.includes(description) ? `the Node driver does not have a collMod helper.` : null
+    SKIPPED_TESTS.includes(description) ? `the Node driver does not have a collMod helper.` : false
   );
 });

test/integration/command-monitoring/command_monitoring.spec.test.ts

@@ -13,6 +13,6 @@ const SKIP = ['A successful unordered bulk write with an unacknowledged write co
 
 describe('Command Monitoring Spec (unified)', () => {
   runUnifiedSuite(loadSpecTests(path.join('command-monitoring', 'unified')), ({ description }) =>
-    SKIP.includes(description) ? `TODO(NODE-4261): support skip reasons in unified tests` : null
+    SKIP.includes(description) ? `TODO(NODE-4261): support skip reasons in unified tests` : false
   );
 });

test/integration/load-balancers/load_balancers.spec.test.js

@@ -22,7 +22,7 @@ const filter = ({ description }) => {
     // TODO(DRIVERS-1847): The above three tests are skipped pending a decision made in DRIVERS-1847
     // since pinning the connection on any getMore error is very awkward in node and likely results
     // in sub-optimal pinning.
-    return 'TODO(DRIVERS-1847): Skipped pending a decision made on DRIVERS-1847'
+    return 'TODO(DRIVERS-1847): Skipped pending a decision made on DRIVERS-1847';
   }
 
   if (description === 'errors during the initial connection hello are ignored') {
@@ -44,7 +44,7 @@ const filter = ({ description }) => {
     return 'TODO(NODE-3891): fix tests broken when AUTH enabled';
   }
 
-  return null;
+  return false;
 };
 
 describe('Load Balancer Unified Tests', function () {

test/integration/unified-test-format/unified_test_format.spec.test.ts

@@ -37,7 +37,7 @@ const filter: TestFilter = ({ description }) => {
     return 'TODO(NODE-3891): fix tests broken when AUTH enabled';
   }
 
-  return null;
+  return false;
 };
 
 describe('Unified test format runner', function unifiedTestRunner() {

test/tools/unified-spec-runner/runner.ts

@@ -44,7 +44,7 @@ export async function runUnifiedTest(
   ctx: Mocha.Context,
   unifiedSuite: uni.UnifiedSuite,
   test: uni.Test,
-  skipFilter: uni.TestFilter = () => null
+  skipFilter: uni.TestFilter = () => false
 ): Promise<void> {
   // Some basic expectations we can catch early
   expect(test).to.exist;
@@ -253,7 +253,7 @@ export async function runUnifiedTest(
  */
 export function runUnifiedSuite(
   specTests: uni.UnifiedSuite[],
-  skipFilter: uni.TestFilter = () => null
+  skipFilter: uni.TestFilter = () => false
 ): void {
   for (const unifiedSuite of specTests) {
     context(String(unifiedSuite.description), function () {

test/tools/unified-spec-runner/schema.ts

@@ -240,4 +240,4 @@ export interface ExpectedError {
 /**
  * A type that represents the test filter provided to the unifed runner.
  */
-export type TestFilter = (test: Test) => null | string;
+export type TestFilter = (test: Test) => string | false;