Skip to content

Commit cf6d523

Browse files
authored
test(NODE-4322): update sessions dirty spec tests (#3296)
1 parent 4a91444 commit cf6d523

File tree

4 files changed

+1
-10
lines changed

4 files changed

+1
-10
lines changed

test/integration/sessions/sessions.spec.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,5 @@ import { loadSpecTests } from '../../spec';
22
import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
33

44
describe('Sessions spec tests', function () {
5-
runUnifiedSuite(loadSpecTests('sessions'), [
6-
// TODO(NODE-3951): fix broken dirty sessions spec tests
7-
'Dirty explicit session is discarded (insert)',
8-
'Dirty explicit session is discarded (findAndModify)'
9-
]);
5+
runUnifiedSuite(loadSpecTests('sessions'));
106
});

test/integration/unified-test-format/unified_test_format.spec.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ const SKIPPED_TESTS = [
1919
// TODO(NODE-2034): Will be implemented as part of NODE-2034
2020
'Client side error in command starting transaction',
2121

22-
// TODO(NODE-3951): investigate why this is failing while the legacy version is passing
23-
'Dirty explicit session is discarded',
24-
2522
// TODO(NODE-3308):
2623
'A successful find event with a getmore and the server kills the cursor',
2724

test/spec/sessions/driver-sessions-dirty-session-errors.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,6 @@
448448
"name": "insertOne",
449449
"object": "collection0",
450450
"arguments": {
451-
"session": "session0",
452451
"document": {
453452
"_id": 2
454453
}

test/spec/sessions/driver-sessions-dirty-session-errors.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ tests:
195195
- name: insertOne
196196
object: *collection0
197197
arguments:
198-
session: *session0
199198
document: { _id: 2 }
200199
expectResult: { $$unsetOrMatches: { insertedId: { $$unsetOrMatches: 2 } } }
201200
- *find_with_implicit_session

0 commit comments

Comments
 (0)