Skip to content

Commit a35de87

Browse files
authored
DRIVERS-1725 Unskip failCommand+appName tests on MongoDB 4.4.7+ (#1612)
1 parent 121be10 commit a35de87

File tree

12 files changed

+17
-19
lines changed

12 files changed

+17
-19
lines changed

source/client-side-operations-timeout/tests/command-execution.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/client-side-operations-timeout/tests/command-execution.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ description: "timeoutMS behaves correctly during command execution"
33
schemaVersion: "1.9"
44

55
runOnRequirements:
6-
# The appName filter cannot be used to set a fail point on connection handshakes until server version 4.9 due to
7-
# SERVER-49220/SERVER-49336.
8-
- minServerVersion: "4.9"
6+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
7+
- minServerVersion: "4.4.7"
98
# Skip load-balanced and serverless which do not support RTT measurements.
109
topologies: [ single, replicaset, sharded ]
1110
serverless: forbid

source/load-balancers/tests/sdam-error-handling.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/load-balancers/tests/sdam-error-handling.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,8 @@ tests:
141141
# to the same mongos on which the failpoint is set.
142142
- description: errors during the initial connection hello are ignored
143143
runOnRequirements:
144-
# Server version 4.9+ is needed to set a fail point on the initial
145-
# connection handshake with the appName filter due to SERVER-49336.
146-
- minServerVersion: '4.9'
144+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
145+
- minServerVersion: '4.4.7'
147146
operations:
148147
- name: failPoint
149148
object: testRunner

source/server-discovery-and-monitoring/tests/unified/hello-command-error.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/server-discovery-and-monitoring/tests/unified/hello-command-error.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ description: hello-command-error
44
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies: [ single, replicaset, sharded ]
1111

source/server-discovery-and-monitoring/tests/unified/hello-network-error.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/server-discovery-and-monitoring/tests/unified/hello-network-error.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ description: hello-network-error
44
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies: [ single, replicaset, sharded ]
1111

source/server-discovery-and-monitoring/tests/unified/interruptInUse-pool-clear.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/server-discovery-and-monitoring/tests/unified/interruptInUse-pool-clear.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ schemaVersion: "1.11"
55

66
runOnRequirements:
77
# failCommand appName requirements
8-
- minServerVersion: "4.9"
8+
- minServerVersion: "4.4"
99
serverless: forbid
1010
topologies: [ replicaset, sharded ]
1111

source/server-discovery-and-monitoring/tests/unified/minPoolSize-error.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/server-discovery-and-monitoring/tests/unified/minPoolSize-error.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ description: minPoolSize-error
44
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies:
1111
- single

0 commit comments

Comments
 (0)