enable go-to-type-definition on type nodes (microsoft#46714)

* enable go-to-type-definition on type nodes

* only go when symbol has no value meaning

* Update formatting of src/services/goToDefinition.ts

Co-authored-by: Nathan Shively-Sanders <[email protected]>

Co-authored-by: Nathan Shively-Sanders <[email protected]>

Author: 2 people

src/services/goToDefinition.ts

@@ -198,14 +198,17 @@ namespace ts.GoToDefinition {
             return undefined;
         }
 
-        const symbol = typeChecker.getSymbolAtLocation(node);
+        const symbol = getSymbol(node, typeChecker);
         if (!symbol) return undefined;
 
         const typeAtLocation = typeChecker.getTypeOfSymbolAtLocation(symbol, node);
         const returnType = tryGetReturnTypeOfFunction(symbol, typeAtLocation, typeChecker);
         const fromReturnType = returnType && definitionFromType(returnType, typeChecker, node);
         // If a function returns 'void' or some other type with no definition, just return the function definition.
-        return fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
+        const typeDefinitions = fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
+        return typeDefinitions.length ? typeDefinitions
+            : !(symbol.flags & SymbolFlags.Value) && symbol.flags & SymbolFlags.Type ? getDefinitionFromSymbol(typeChecker, skipAlias(symbol, typeChecker), node)
+            : undefined;
     }
 
     function definitionFromType(type: Type, checker: TypeChecker, node: Node): readonly DefinitionInfo[] {

tests/cases/fourslash/goToTypeDefinition3.ts

@@ -0,0 +1,6 @@
+/// <reference path='fourslash.ts' />
+
+////type /*definition*/T = string;
+////const x: /*reference*/T;
+
+verify.goToType("reference", "definition");

tests/cases/fourslash/goToTypeDefinition4.ts

@@ -0,0 +1,12 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: foo.ts
+////export type /*def0*/T = string;
+////export const /*def1*/T = "";
+
+// @Filename: bar.ts
+////import { T } from "./foo";
+////let x: [|/*reference*/T|];
+
+verify.goToType("reference", []);
+verify.goToDefinition("reference", ["def0", "def1"]);

tests/cases/fourslash/goToTypeDefinition5.ts

@@ -0,0 +1,10 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: foo.ts
+////let Foo: /*definition*/unresolved;
+////type Foo = { x: string };
+
+/////*reference*/Foo;
+
+
+verify.goToType("reference", []);