Skip to content

Commit 3cd7430

Browse files
bpastenechromeos-ci-prod
authored andcommitted
Ensure the 'en_US.utf8' locale is installed via install-build-deps
In recent jammy upgrades of some machine types, we've noticed that they don't have the en_US.utf8 installed or set as the default, leading to some test failures, eg: https://luci-milo.appspot.com/ui/p/chrome/builders/ci/linux64/142828/overview install-build-deps tries to install needed locales, but skips en_US.utf8, probably because it's never been needed before. But apparently starting with jammy it looks like it is needed. So this will just explicitly install that locale as well. Should be safe if it's already installed. Bug: b/304850354 Change-Id: I836401ee5853dd7b41f61d86a8ca650fc9b326f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4932673 Reviewed-by: Thomas Anderson <[email protected]> Commit-Queue: Ben Pastene <[email protected]> Cr-Commit-Position: refs/heads/main@{#1208920} CrOS-Libchrome-Original-Commit: d584e918146f9e94b6590c167a9369b31659a0aa
1 parent fd7c998 commit 3cd7430

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/install-build-deps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ def install_chromeos_fonts(options):
875875
def install_locales():
876876
print("Installing locales.", file=sys.stderr)
877877
CHROMIUM_LOCALES = [
878-
"da_DK.UTF-8", "fr_FR.UTF-8", "he_IL.UTF-8", "zh_TW.UTF-8"
878+
"da_DK.UTF-8", "en_US.utf8", "fr_FR.UTF-8", "he_IL.UTF-8", "zh_TW.UTF-8"
879879
]
880880
LOCALE_GEN = "/etc/locale.gen"
881881
if os.path.exists(LOCALE_GEN):

0 commit comments

Comments
 (0)