Skip to content

Commit 3043cbc

Browse files
committed
[AArch64] Further enable UnrollAndJam
Due to the dependency on runtime unrolling, UnJ is only enabled by default on in-order scheduling models, and if a cpu is specified through -mcpu. Differential Revision: https://reviews.llvm.org/D103604
1 parent b5dea87 commit 3043cbc

File tree

2 files changed

+98
-0
lines changed

2 files changed

+98
-0
lines changed

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,6 +1405,9 @@ void AArch64TTIImpl::getUnrollingPreferences(Loop *L, ScalarEvolution &SE,
14051405
UP.UpperBound = true;
14061406
UP.UnrollRemainder = true;
14071407
UP.DefaultUnrollRuntimeCount = 4;
1408+
1409+
UP.UnrollAndJam = true;
1410+
UP.UnrollAndJamInnerLoopThreshold = 60;
14081411
}
14091412
}
14101413

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -passes='loop-unroll-and-jam' < %s -mcpu=cortex-a55 -mtriple=aarch64-none-linux-eabi -S | FileCheck %s
3+
4+
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
5+
6+
define void @unj(i32 %I, i32 %argj, i32* noalias nocapture %A, i32* noalias nocapture readonly %B) #0 {
7+
; CHECK-LABEL: @unj(
8+
; CHECK-NEXT: entry:
9+
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[ARGJ:%.*]], 0
10+
; CHECK-NEXT: br i1 [[CMP]], label [[FOR_END:%.*]], label [[FOR_PREHEADER:%.*]]
11+
; CHECK: for.preheader:
12+
; CHECK-NEXT: br label [[FOR_OUTER:%.*]]
13+
; CHECK: for.outer:
14+
; CHECK-NEXT: br label [[FOR_INNER:%.*]]
15+
; CHECK: for.inner:
16+
; CHECK-NEXT: [[J:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[INC:%.*]], [[FOR_INNER]] ]
17+
; CHECK-NEXT: [[SUM:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[ADD:%.*]], [[FOR_INNER]] ]
18+
; CHECK-NEXT: [[J_1:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[INC_1:%.*]], [[FOR_INNER]] ]
19+
; CHECK-NEXT: [[SUM_1:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[ADD_1:%.*]], [[FOR_INNER]] ]
20+
; CHECK-NEXT: [[J_2:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[INC_2:%.*]], [[FOR_INNER]] ]
21+
; CHECK-NEXT: [[SUM_2:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[ADD_2:%.*]], [[FOR_INNER]] ]
22+
; CHECK-NEXT: [[J_3:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[INC_3:%.*]], [[FOR_INNER]] ]
23+
; CHECK-NEXT: [[SUM_3:%.*]] = phi i32 [ 0, [[FOR_OUTER]] ], [ [[ADD_3:%.*]], [[FOR_INNER]] ]
24+
; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, i32* [[B:%.*]], i32 [[J]]
25+
; CHECK-NEXT: [[TMP0:%.*]] = load i32, i32* [[ARRAYIDX]], align 4
26+
; CHECK-NEXT: [[SUB:%.*]] = add i32 [[SUM]], 10
27+
; CHECK-NEXT: [[ADD]] = sub i32 [[SUB]], [[TMP0]]
28+
; CHECK-NEXT: [[INC]] = add nuw i32 [[J]], 1
29+
; CHECK-NEXT: [[ARRAYIDX_1:%.*]] = getelementptr inbounds i32, i32* [[B]], i32 [[J_1]]
30+
; CHECK-NEXT: [[TMP1:%.*]] = load i32, i32* [[ARRAYIDX_1]], align 4
31+
; CHECK-NEXT: [[SUB_1:%.*]] = add i32 [[SUM_1]], 10
32+
; CHECK-NEXT: [[ADD_1]] = sub i32 [[SUB_1]], [[TMP1]]
33+
; CHECK-NEXT: [[INC_1]] = add nuw i32 [[J_1]], 1
34+
; CHECK-NEXT: [[ARRAYIDX_2:%.*]] = getelementptr inbounds i32, i32* [[B]], i32 [[J_2]]
35+
; CHECK-NEXT: [[TMP2:%.*]] = load i32, i32* [[ARRAYIDX_2]], align 4
36+
; CHECK-NEXT: [[SUB_2:%.*]] = add i32 [[SUM_2]], 10
37+
; CHECK-NEXT: [[ADD_2]] = sub i32 [[SUB_2]], [[TMP2]]
38+
; CHECK-NEXT: [[INC_2]] = add nuw i32 [[J_2]], 1
39+
; CHECK-NEXT: [[ARRAYIDX_3:%.*]] = getelementptr inbounds i32, i32* [[B]], i32 [[J_3]]
40+
; CHECK-NEXT: [[TMP3:%.*]] = load i32, i32* [[ARRAYIDX_3]], align 4
41+
; CHECK-NEXT: [[SUB_3:%.*]] = add i32 [[SUM_3]], 10
42+
; CHECK-NEXT: [[ADD_3]] = sub i32 [[SUB_3]], [[TMP3]]
43+
; CHECK-NEXT: [[INC_3]] = add nuw i32 [[J_3]], 1
44+
; CHECK-NEXT: [[EXITCOND_3:%.*]] = icmp eq i32 [[INC_3]], [[ARGJ]]
45+
; CHECK-NEXT: br i1 [[EXITCOND_3]], label [[FOR_LATCH:%.*]], label [[FOR_INNER]]
46+
; CHECK: for.latch:
47+
; CHECK-NEXT: [[ADD_LCSSA:%.*]] = phi i32 [ [[ADD]], [[FOR_INNER]] ]
48+
; CHECK-NEXT: [[ADD_LCSSA_1:%.*]] = phi i32 [ [[ADD_1]], [[FOR_INNER]] ]
49+
; CHECK-NEXT: [[ADD_LCSSA_2:%.*]] = phi i32 [ [[ADD_2]], [[FOR_INNER]] ]
50+
; CHECK-NEXT: [[ADD_LCSSA_3:%.*]] = phi i32 [ [[ADD_3]], [[FOR_INNER]] ]
51+
; CHECK-NEXT: store i32 [[ADD_LCSSA]], i32* [[A:%.*]], align 4
52+
; CHECK-NEXT: [[ARRAYIDX6_1:%.*]] = getelementptr inbounds i32, i32* [[A]], i32 1
53+
; CHECK-NEXT: store i32 [[ADD_LCSSA_1]], i32* [[ARRAYIDX6_1]], align 4
54+
; CHECK-NEXT: [[ARRAYIDX6_2:%.*]] = getelementptr inbounds i32, i32* [[A]], i32 2
55+
; CHECK-NEXT: store i32 [[ADD_LCSSA_2]], i32* [[ARRAYIDX6_2]], align 4
56+
; CHECK-NEXT: [[ARRAYIDX6_3:%.*]] = getelementptr inbounds i32, i32* [[A]], i32 3
57+
; CHECK-NEXT: store i32 [[ADD_LCSSA_3]], i32* [[ARRAYIDX6_3]], align 4
58+
; CHECK-NEXT: br label [[FOR_END_LOOPEXIT:%.*]]
59+
; CHECK: for.end.loopexit:
60+
; CHECK-NEXT: br label [[FOR_END]]
61+
; CHECK: for.end:
62+
; CHECK-NEXT: ret void
63+
;
64+
entry:
65+
%cmp = icmp eq i32 %argj, 0
66+
br i1 %cmp, label %for.end, label %for.preheader
67+
68+
for.preheader:
69+
br label %for.outer
70+
71+
for.outer:
72+
%i = phi i32 [ %add8, %for.latch ], [ 0, %for.preheader ]
73+
br label %for.inner
74+
75+
for.inner:
76+
%j = phi i32 [ 0, %for.outer ], [ %inc, %for.inner ]
77+
%sum = phi i32 [ 0, %for.outer ], [ %add, %for.inner ]
78+
%arrayidx = getelementptr inbounds i32, i32* %B, i32 %j
79+
%0 = load i32, i32* %arrayidx, align 4
80+
%sub = add i32 %sum, 10
81+
%add = sub i32 %sub, %0
82+
%inc = add nuw i32 %j, 1
83+
%exitcond = icmp eq i32 %inc, %argj
84+
br i1 %exitcond, label %for.latch, label %for.inner
85+
86+
for.latch:
87+
%arrayidx6 = getelementptr inbounds i32, i32* %A, i32 %i
88+
store i32 %add, i32* %arrayidx6, align 4
89+
%add8 = add nuw nsw i32 %i, 1
90+
%exitcond23 = icmp eq i32 %add8, 4
91+
br i1 %exitcond23, label %for.end, label %for.outer
92+
93+
for.end:
94+
ret void
95+
}

0 commit comments

Comments
 (0)