fix streams

Author: mtarld

Stream/InputStream.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\Marshaller\Stream;
+
+final class InputStream extends Stream
+{
+    public function __construct()
+    {
+        parent::__construct('php://input', 'placeholder');
+    }
+}

Stream/MemoryStream.php

@@ -6,8 +6,8 @@
 
 final class MemoryStream extends Stream
 {
-    public function __construct()
+    public function __construct(string $mode = 'w+b')
     {
-        parent::__construct('php://memory', readable: true, writable: true);
+        parent::__construct('php://memory', $mode);
     }
 }

Stream/OutputStream.php

@@ -8,6 +8,6 @@ final class OutputStream extends Stream
 {
     public function __construct()
     {
-        parent::__construct('php://output', readable: true, writable: false);
+        parent::__construct('php://output', 'placeholder');
     }
 }

Stream/StdinStream.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\Marshaller\Stream;
+
+final class StdinStream extends Stream
+{
+    public function __construct()
+    {
+        parent::__construct('php://stdin', 'placeholder');
+    }
+}

Stream/StdoutStream.php

@@ -8,6 +8,6 @@ final class StdoutStream extends Stream
 {
     public function __construct()
     {
-        parent::__construct('php://stdout', readable: true, writable: false);
+        parent::__construct('php://stdout', 'placeholder');
     }
 }

Stream/Stream.php

@@ -13,8 +13,7 @@ abstract class Stream implements StreamInterface
 
     protected function __construct(
         protected readonly string $filename,
-        protected bool $readable,
-        protected bool $writable,
+        protected readonly string $mode,
     ) {
     }
 
@@ -24,9 +23,7 @@ final public function stream()
             return $this->stream;
         }
 
-        $mode = sprintf('%s%sb', $this->readable ? 'r' : '', $this->writable ? 'w' : '');
-
-        if (false === $stream = fopen($this->filename, $mode)) {
+        if (false === $stream = fopen($this->filename, $this->mode)) {
             throw new \RuntimeException(sprintf('Cannot open "%s" stream', $this->filename));
         }
 

Stream/TempStream.php

@@ -6,8 +6,8 @@
 
 final class TempStream extends Stream
 {
-    public function __construct(int $memoryThreshold = 2048)
+    public function __construct(int $memoryThreshold = 2048, string $mode = 'w+b')
     {
-        parent::__construct(sprintf('php://temp/maxmemory:%d', $memoryThreshold), readable: true, writable: true);
+        parent::__construct(sprintf('php://temp/maxmemory:%d', $memoryThreshold), $mode);
     }
 }

Tests/Stream/StreamTest.php

@@ -14,7 +14,7 @@ public function testCreateStream(): void
         $stream = new class () extends Stream {
             public function __construct()
             {
-                parent::__construct('php://memory', readable: true, writable: true);
+                parent::__construct('php://memory', 'w+b');
             }
         };
 
@@ -29,7 +29,7 @@ public function testToString(): void
         $stream = new class () extends Stream {
             public function __construct()
             {
-                parent::__construct('php://memory', readable: true, writable: true);
+                parent::__construct('php://memory', 'w+b');
             }
         };