bug symfony#45572 [HttpKernel] fix using Target attribute with controller arguments (kbond)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpKernel] fix using Target attribute with controller arguments

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#45021
| License       | MIT
| Doc PR        | n/a

This was supposed to fix symfony#45021 but after adding what I suspected was a failing test, it works as expected. I guess I'm not testing the correct thing?

Here's a quick reproducer that shows the problem in a "real app":

```php
class HomepageController extends AbstractController
{
    public function __construct(#[Target('request.logger')] private LoggerInterface $logger)
    {
    }

    #[Route('/', name: 'app_homepage')]
    public function index(#[Target('request.logger')] LoggerInterface $logger): Response
    {
        dd(
            $this->logger->getName(), // "request" (expected)
            $logger->getName()        // "app" (not-expected)
        );

        // ...
    }
}
```

Commits
-------

448cc3a [HttpKernel] fix using Target with controller args

Author: nicolas-grekas

src/Symfony/Component/HttpKernel/DependencyInjection/RegisterControllerArgumentLocatorsPass.php

@@ -192,7 +192,7 @@ public function process(ContainerBuilder $container)
                         $args[$p->name] = new Reference($erroredId, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE);
                     } else {
                         $target = ltrim($target, '\\');
-                        $args[$p->name] = $type ? new TypedReference($target, $type, $invalidBehavior, $p->name) : new Reference($target, $invalidBehavior);
+                        $args[$p->name] = $type ? new TypedReference($target, $type, $invalidBehavior, Target::parseName($p)) : new Reference($target, $invalidBehavior);
                     }
                 }
                 // register the maps as a per-method service-locators

src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

@@ -428,6 +428,9 @@ public function testBindWithTarget()
         $container = new ContainerBuilder();
         $resolver = $container->register('argument_resolver.service')->addArgument([]);
 
+        $container->register(ControllerDummy::class, 'bar');
+        $container->register(ControllerDummy::class.' $imageStorage', 'baz');
+
         $container->register('foo', WithTarget::class)
             ->setBindings(['string $someApiKey' => new Reference('the_api_key')])
             ->addTag('controller.service_arguments');
@@ -437,7 +440,11 @@ public function testBindWithTarget()
         $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
         $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
 
-        $expected = ['apiKey' => new ServiceClosureArgument(new Reference('the_api_key'))];
+        $expected = [
+            'apiKey' => new ServiceClosureArgument(new Reference('the_api_key')),
+            'service1' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE, 'imageStorage')),
+            'service2' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE, 'service2')),
+        ];
         $this->assertEquals($expected, $locator->getArgument(0));
     }
 }
@@ -513,7 +520,10 @@ class WithTarget
 {
     public function fooAction(
         #[Target('some.api.key')]
-        string $apiKey
+        string $apiKey,
+        #[Target('image.storage')]
+        ControllerDummy $service1,
+        ControllerDummy $service2
     ) {
     }
 }