deserializer metadata tests wip

Author: mtarld

src/Symfony/Component/Serializer/Deserialize/Mapping/TypePropertyMetadataLoader.php

@@ -44,7 +44,7 @@ public function load(string $className, DeserializeConfig $config, array $contex
                 $metadata = $metadata->withType($this->typeGenericsHelper->replaceGenericTypes($type, $genericTypes));
             }
 
-            if ($type->isObject() && $type->hasClass() && is_a(\DateTimeInterface::class, $type->className(), true)) {
+            if ($type->isObject() && $type->hasClass() && is_a($type->className(), \DateTimeInterface::class, true)) {
                 $metadata = $metadata
                     ->withType(Type::string())
                     ->withFormatter(self::castStringToDateTime(...));

src/Symfony/Component/Serializer/Serialize/Mapping/TypePropertyMetadataLoader.php

@@ -45,7 +45,7 @@ public function load(string $className, SerializeConfig $config, array $context)
                 $metadata = $metadata->withType($this->typeGenericsHelper->replaceGenericTypes($type, $genericTypes));
             }
 
-            if ($type->isObject() && $type->hasClass() && is_a(\DateTimeInterface::class, $type->className(), true)) {
+            if ($type->isObject() && $type->hasClass() && is_a($type->className(), \DateTimeInterface::class, true)) {
                 $metadata = $metadata
                     ->withType(Type::string())
                     ->withFormatter(self::castDateTimeToString(...));

src/Symfony/Component/Serializer/Tests/Deserialize/Metadata/PropertyMetadataTest.php

@@ -12,7 +12,22 @@
 namespace Symfony\Component\Serializer\Tests\Deserialize\Metadata;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Serializer\Deserialize\Mapping\PropertyMetadata;
+use Symfony\Component\Serializer\Exception\InvalidArgumentException;
+use Symfony\Component\Serializer\Tests\Fixtures\Dto\DummyWithMethods;
+use Symfony\Component\Serializer\Type\Type;
 
 class PropertyMetadataTest extends TestCase
 {
+    public function testThrowOnNonStaticFormatter()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        new PropertyMetadata('useless', Type::mixed(), [(new DummyWithMethods())->nonStatic(...)]);
+    }
+
+    public function testThrowOnNonAnonymousFormatter()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        new PropertyMetadata('useless', Type::mixed(), [fn () => 'useless']);
+    }
 }

src/Symfony/Component/Serializer/Tests/Deserialize/Metadata/TypePropertyMetadataLoaderTest.php

@@ -12,7 +12,77 @@
 namespace Symfony\Component\Serializer\Tests\Deserialize\Metadata;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Serializer\Deserialize\Config\DeserializeConfig;
+use Symfony\Component\Serializer\Deserialize\Mapping\PropertyMetadata;
+use Symfony\Component\Serializer\Deserialize\Mapping\PropertyMetadataLoaderInterface;
+use Symfony\Component\Serializer\Deserialize\Mapping\TypePropertyMetadataLoader;
+use Symfony\Component\Serializer\Tests\Fixtures\Dto\DummyWithGenerics;
+use Symfony\Component\Serializer\Type\Type;
+use Symfony\Component\Serializer\Type\TypeExtractorInterface;
 
 class TypePropertyMetadataLoaderTest extends TestCase
 {
+    public function testCastDateTimeToString()
+    {
+        $loader = new TypePropertyMetadataLoader(self::propertyMetadataLoader([
+            'foo' => new PropertyMetadata('foo', Type::class(\DateTimeImmutable::class), []),
+        ]), $this->createStub(TypeExtractorInterface::class));
+
+        $metadata = $loader->load(self::class, new DeserializeConfig(), ['original_type' => Type::fromString('useless')]);
+
+        $this->assertEquals([
+            'foo' => new PropertyMetadata('foo', Type::string(), [
+                \Closure::fromCallable(TypePropertyMetadataLoader::castStringToDateTime(...)),
+            ]),
+        ], $metadata);
+
+        $formatter = $metadata['foo']->formatters()[0];
+
+        $this->assertEquals(
+            new \DateTimeImmutable('2023-07-26'),
+            $formatter('2023-07-26', new DeserializeConfig()),
+        );
+
+        $this->assertEquals(
+            (new \DateTimeImmutable('2023-07-26'))->setTime(0, 0),
+            $formatter('26/07/2023 00:00:00', (new DeserializeConfig())->withDateTimeFormat('d/m/Y H:i:s')),
+        );
+    }
+
+    public function testReplaceGenerics()
+    {
+        $typeExtractor = $this->createStub(TypeExtractorInterface::class);
+        $typeExtractor->method('extractTemplateFromClass')->willReturn(['T']);
+
+        $loader = new TypePropertyMetadataLoader(self::propertyMetadataLoader([
+            'foo' => new PropertyMetadata('foo', Type::fromString('T'), []),
+        ]), $typeExtractor);
+
+        $metadata = $loader->load(
+            DummyWithGenerics::class,
+            new DeserializeConfig(),
+            ['original_type' => Type::class(DummyWithGenerics::class, genericParameterTypes: [Type::int()])],
+        );
+
+        $this->assertEquals([
+            'foo' => new PropertyMetadata('foo', Type::int(), []),
+        ], $metadata);
+    }
+
+    /**
+     * @param array<string, PropertyMetadata> $propertiesMetadata
+     */
+    private static function propertyMetadataLoader(array $propertiesMetadata = []): PropertyMetadataLoaderInterface
+    {
+        return new class($propertiesMetadata) implements PropertyMetadataLoaderInterface {
+            public function __construct(private readonly array $propertiesMetadata)
+            {
+            }
+
+            public function load(string $className, DeserializeConfig $config, array $context): array
+            {
+                return $this->propertiesMetadata;
+            }
+        };
+    }
 }