minor symfony#58461 [ExpressionLanguage] Improve tests on BinaryNode (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[ExpressionLanguage] Improve tests on `BinaryNode`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

`in` and `not in` have a shortcut above the operator switch. Also, `BinaryNode::evaluate()` may throw an error, lacking a return value when the operator is unsupported.

Commits
-------

c03cbe3 [ExpressionLanguage] Improve tests on `BinaryNode`

Author: fabpot

src/Symfony/Component/ExpressionLanguage/Node/BinaryNode.php

@@ -154,10 +154,6 @@ public function evaluate(array $functions, array $values): mixed
                 return $left >= $right;
             case '<=':
                 return $left <= $right;
-            case 'not in':
-                return !\in_array($left, $right, true);
-            case 'in':
-                return \in_array($left, $right, true);
             case '+':
                 return $left + $right;
             case '-':
@@ -181,6 +177,8 @@ public function evaluate(array $functions, array $values): mixed
             case 'matches':
                 return $this->evaluateMatches($right, $left);
         }
+
+        throw new \LogicException(\sprintf('"%s" does not support the "%s" operator.', __CLASS__, $operator));
     }
 
     public function toArray(): array

src/Symfony/Component/ExpressionLanguage/Tests/Node/BinaryNodeTest.php

@@ -279,4 +279,14 @@ public function testInOperatorStrictness(mixed $value)
 
         $this->assertFalse($node->evaluate([], []));
     }
+
+    public function testEvaluateUnsupportedOperator()
+    {
+        $node = new BinaryNode('unsupported', new ConstantNode(1), new ConstantNode(2));
+
+        $this->expectException(\LogicException::class);
+        $this->expectExceptionMessage('"Symfony\Component\ExpressionLanguage\Node\BinaryNode" does not support the "unsupported" operator.');
+
+        $node->evaluate([], []);
+    }
 }