Closes #16. Skip final static fields.

Author: emacarron

src/main/java/org/apache/ibatis/executor/resultset/FastResultSetHandler.java

@@ -346,7 +346,7 @@ protected boolean applyAutomaticMappings(ResultSet rs, List<String> unmappedColu
         }
       }
       final String property = metaObject.findProperty(propertyName, configuration.isMapUnderscoreToCamelCase());
-      if (property != null &&metaObject.hasSetter(property) ) {
+      if (property != null && metaObject.hasSetter(property)) {
         final Class<?> propertyType = metaObject.getSetterType(property);
         if (typeHandlerRegistry.hasTypeHandler(propertyType)) {
           final TypeHandler<?> typeHandler = resultColumnCache.getTypeHandler(propertyType, columnName);

src/main/java/org/apache/ibatis/reflection/Reflector.java

@@ -225,13 +225,15 @@ private void addFields(Class<?> clazz) {
           // Ignored. This is only a final precaution, nothing we can do.
         }
       }
-      int modifier=field.getModifiers();
-      // issue 379 - removed the check for final because JDK 1.5 allows
-      // modification of final fields through reflection (JSR-133).  (JGB)
-      // allow final but not final static
-      if (field.isAccessible() && !(Modifier.isFinal(modifier) && Modifier.isStatic(modifier))) {
-      if (!setMethods.containsKey(field.getName())) {
-          addSetField(field);
+      if (field.isAccessible()) {
+        if (!setMethods.containsKey(field.getName())) {
+          // issue #379 - removed the check for final because JDK 1.5 allows
+          // modification of final fields through reflection (JSR-133). (JGB)
+          // pr #16 - final static can only be set by the classloader
+          int modifiers = field.getModifiers();
+          if (!(Modifier.isFinal(modifiers) && Modifier.isStatic(modifiers))) {
+            addSetField(field);
+          }
         }
         if (!getMethods.containsKey(field.getName())) {
           addGetField(field);

src/test/java/org/apache/ibatis/submitted/automapping/Book.java

@@ -16,15 +16,15 @@
 package org.apache.ibatis.submitted.automapping;
 
 public class Book {
-	public static final Integer version=0;
-	private String name;
+  public static final Integer version = 0;
+  private String name;
 
-	public String getName() {
-		return name;
-	}
+  public String getName() {
+    return name;
+  }
 
-	public void setName(String name) {
-		this.name = name;
-	}
+  public void setName(String name) {
+    this.name = name;
+  }
 
 }

src/test/java/org/apache/ibatis/submitted/automapping/Mapper.xml

@@ -32,7 +32,7 @@
 	</resultMap>
 
 	<select id="getBooks" resultMap="bookResult">
-		select version,name from books
+		select version, name from books
 	</select>
 
 	<select id="getArticle" resultType="org.apache.ibatis.submitted.automapping.Article">