Removed resolveParamTypes() as it was not necessary to fix #321.

Author: harawata

src/main/java/org/apache/ibatis/reflection/TypeParameterResolver.java

@@ -23,24 +23,6 @@
 
 public class TypeParameterResolver {
 
-  public static Type[] resolveParamTypes(Method method, Type mapper) {
-    Type[] paramTypes = method.getGenericParameterTypes();
-    Class<?> declaringClass = method.getDeclaringClass();
-    Type[] result = new Type[paramTypes.length];
-    for (int i = 0; i < paramTypes.length; i++) {
-      if (paramTypes[i] instanceof Class) {
-        result[i] = paramTypes[i];
-      } else if (paramTypes[i] instanceof TypeVariable) {
-        result[i] = resolveTypeVar((TypeVariable<?>) paramTypes[i], mapper, declaringClass);
-      } else if (paramTypes[i] instanceof ParameterizedType) {
-        result[i] = resolveParameterizedType((ParameterizedType) paramTypes[i], mapper, declaringClass);
-      } else {
-        // TODO: other types?
-      }
-    }
-    return result;
-  }
-
   public static Type resolveReturnType(Method method, Type mapper) {
     Type returnType = method.getGenericReturnType();
     Class<?> declaringClass = method.getDeclaringClass();

src/test/java/org/apache/ibatis/reflection/TypeParameterResolverTest.java

@@ -216,63 +216,4 @@ public void testReturn_LV2Map() throws Exception {
     assertEquals(String.class, paramType.getActualTypeArguments()[0]);
     assertEquals(Integer.class, paramType.getActualTypeArguments()[1]);
   }
-
-  @Test
-  public void testParam_Primitive() throws Exception {
-    Class<?> clazz = Level2Mapper.class;
-    Method method = clazz.getMethod("simpleSelectPrimitive", int.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(1, result.length);
-    assertEquals(int.class, result[0]);
-  }
-
-  @Test
-  public void testParam_Simple() throws Exception {
-    Class<?> clazz = Level1Mapper.class;
-    Method method = clazz.getMethod("simpleSelectVoid", Integer.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(1, result.length);
-    assertEquals(Integer.class, result[0]);
-  }
-
-  @Test
-  public void testParam_Lv1Single() throws Exception {
-    Class<?> clazz = Level1Mapper.class;
-    Method method = clazz.getMethod("select", Object.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(1, result.length);
-    assertEquals(String.class, result[0]);
-  }
-
-  @Test
-  public void testParam_Lv2Single() throws Exception {
-    Class<?> clazz = Level2Mapper.class;
-    Method method = clazz.getMethod("select", Object.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(1, result.length);
-    assertEquals(String.class, result[0]);
-  }
-
-  @Test
-  public void testParam_Lv2Multiple() throws Exception {
-    Class<?> clazz = Level2Mapper.class;
-    Method method = clazz.getMethod("selectList", Object.class, Object.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(2, result.length);
-    assertEquals(Integer.class, result[0]);
-    assertEquals(String.class, result[1]);
-  }
-
-  @Test
-  public void testParam_Lv2CustomClass() throws Exception {
-    Class<?> clazz = Level2Mapper.class;
-    Method method = clazz.getMethod("selectCalculator", Calculator.class);
-    Type[] result = TypeParameterResolver.resolveParamTypes(method, clazz);
-    assertEquals(1, result.length);
-    assertTrue(result[0] instanceof ParameterizedType);
-    ParameterizedType paramType = (ParameterizedType) result[0];
-    assertEquals(Calculator.class, paramType.getRawType());
-    assertEquals(1, paramType.getActualTypeArguments().length);
-    assertEquals(String.class, paramType.getActualTypeArguments()[0]);
-  }
 }