Skip to content

Commit da549fd

Browse files
author
ct
committed
just minor refine.
1 parent 6592180 commit da549fd

File tree

4 files changed

+34
-48
lines changed

4 files changed

+34
-48
lines changed

src/main/java/org/apache/ibatis/reflection/MetaClass.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,8 @@ public boolean hasSetter(String name) {
140140
if (reflector.hasSetter(prop.getName())) {
141141
MetaClass metaProp = metaClassForProperty(prop.getName());
142142
return metaProp.hasSetter(prop.getChildren());
143-
} else {
144-
return false;
145143
}
144+
return false;
146145
}
147146

148147
public boolean hasGetter(String name) {
@@ -153,9 +152,8 @@ public boolean hasGetter(String name) {
153152
if (reflector.hasGetter(prop.getName())) {
154153
MetaClass metaProp = metaClassForProperty(prop);
155154
return metaProp.hasGetter(prop.getChildren());
156-
} else {
157-
return false;
158155
}
156+
return false;
159157
}
160158

161159
public Invoker getGetInvoker(String name) {

src/main/java/org/apache/ibatis/reflection/MetaObject.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,8 @@ public Object getValue(String name) {
118118
MetaObject metaValue = metaObjectForProperty(prop.getIndexedName());
119119
if (metaValue == SystemMetaObject.NULL_META_OBJECT) {
120120
return null;
121-
} else {
122-
return metaValue.getValue(prop.getChildren());
123121
}
122+
return metaValue.getValue(prop.getChildren());
124123
}
125124

126125
public void setValue(String name, Object value) {

src/main/java/org/apache/ibatis/reflection/wrapper/BeanWrapper.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,8 @@ public Class<?> getSetterType(String name) {
8383
MetaObject metaValue = metaObject.metaObjectForProperty(prop.getIndexedName());
8484
if (metaValue == SystemMetaObject.NULL_META_OBJECT) {
8585
return metaClass.getSetterType(name);
86-
} else {
87-
return metaValue.getSetterType(prop.getChildren());
8886
}
87+
return metaValue.getSetterType(prop.getChildren());
8988
}
9089

9190
@Override
@@ -97,9 +96,8 @@ public Class<?> getGetterType(String name) {
9796
MetaObject metaValue = metaObject.metaObjectForProperty(prop.getIndexedName());
9897
if (metaValue == SystemMetaObject.NULL_META_OBJECT) {
9998
return metaClass.getGetterType(name);
100-
} else {
101-
return metaValue.getGetterType(prop.getChildren());
10299
}
100+
return metaValue.getGetterType(prop.getChildren());
103101
}
104102

105103
@Override
@@ -112,12 +110,10 @@ public boolean hasSetter(String name) {
112110
MetaObject metaValue = metaObject.metaObjectForProperty(prop.getIndexedName());
113111
if (metaValue == SystemMetaObject.NULL_META_OBJECT) {
114112
return metaClass.hasSetter(name);
115-
} else {
116-
return metaValue.hasSetter(prop.getChildren());
117113
}
118-
} else {
119-
return false;
114+
return metaValue.hasSetter(prop.getChildren());
120115
}
116+
return false;
121117
}
122118

123119
@Override
@@ -130,12 +126,10 @@ public boolean hasGetter(String name) {
130126
MetaObject metaValue = metaObject.metaObjectForProperty(prop.getIndexedName());
131127
if (metaValue == SystemMetaObject.NULL_META_OBJECT) {
132128
return metaClass.hasGetter(name);
133-
} else {
134-
return metaValue.hasGetter(prop.getChildren());
135129
}
136-
} else {
137-
return false;
130+
return metaValue.hasGetter(prop.getChildren());
138131
}
132+
return false;
139133
}
140134

141135
@Override

src/main/java/org/apache/ibatis/scripting/xmltags/TrimSqlNode.java

Lines changed: 25 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -122,40 +122,35 @@ public String getSql() {
122122
}
123123

124124
private void applyPrefix(StringBuilder sql, String trimmedUppercaseSql) {
125-
if (!prefixApplied) {
126-
prefixApplied = true;
127-
if (prefixesToOverride != null) {
128-
for (String toRemove : prefixesToOverride) {
129-
if (trimmedUppercaseSql.startsWith(toRemove)) {
130-
sql.delete(0, toRemove.trim().length());
131-
break;
132-
}
133-
}
134-
}
135-
if (prefix != null) {
136-
sql.insert(0, " ");
137-
sql.insert(0, prefix);
138-
}
125+
if(prefixApplied) {
126+
return;
127+
}
128+
prefixApplied = true;
129+
if (prefixesToOverride != null) {
130+
prefixesToOverride.stream().filter(trimmedUppercaseSql::startsWith)
131+
.findFirst().ifPresent(toRemove-> sql.delete(0, toRemove.trim().length()));
132+
}
133+
if (prefix != null) {
134+
sql.insert(0, " ").insert(0, prefix);
139135
}
140136
}
141137

142138
private void applySuffix(StringBuilder sql, String trimmedUppercaseSql) {
143-
if (!suffixApplied) {
144-
suffixApplied = true;
145-
if (suffixesToOverride != null) {
146-
for (String toRemove : suffixesToOverride) {
147-
if (trimmedUppercaseSql.endsWith(toRemove) || trimmedUppercaseSql.endsWith(toRemove.trim())) {
148-
int start = sql.length() - toRemove.trim().length();
149-
int end = sql.length();
150-
sql.delete(start, end);
151-
break;
152-
}
153-
}
154-
}
155-
if (suffix != null) {
156-
sql.append(" ");
157-
sql.append(suffix);
158-
}
139+
if (suffixApplied) {
140+
return;
141+
}
142+
suffixApplied = true;
143+
if (suffixesToOverride != null) {
144+
suffixesToOverride.stream()
145+
.filter(toRemove -> trimmedUppercaseSql.endsWith(toRemove) || trimmedUppercaseSql.endsWith(toRemove.trim()))
146+
.findFirst().ifPresent(toRemove -> {
147+
int start = sql.length() - toRemove.trim().length();
148+
int end = sql.length();
149+
sql.delete(start, end);
150+
});
151+
}
152+
if (suffix != null) {
153+
sql.append(" ").append(suffix);
159154
}
160155
}
161156

0 commit comments

Comments
 (0)