Skip to content

Commit ee0d063

Browse files
Merge branch 'master' into convert-md-en
# Conflicts: # src/site/xdoc/configuration.xml # src/site/xdoc/logging.xml # src/site/xdoc/sqlmap-xml.xml
2 parents d1654a6 + e219318 commit ee0d063

File tree

766 files changed

+10779
-8600
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

766 files changed

+10779
-8600
lines changed

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Set default behaviour, in case users don't have core.autocrlf set.
2-
* text=auto
2+
* text=auto

.github/workflows/ci.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,20 @@ jobs:
4040
- name: Set argLine command line option
4141
if: ${{ matrix.java == '11' }}
4242
run: echo 'ARG_LINE=-D"argLine=--illegal-access=permit"' >> $GITHUB_ENV
43+
- name: Run all tests
44+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.java == '11' }}
45+
run: echo 'ARG_LINE=-D"excludedGroups="' >> $GITHUB_ENV
4346
- name: Skip tests that require illegal reflective access
4447
if: ${{ matrix.os == 'ubuntu-latest' && matrix.java != '11' }}
4548
run: echo 'ARG_LINE=-D"excludedGroups=RequireIllegalAccess"' >> $GITHUB_ENV
4649
- name: Skip tests that require illegal reflective access
4750
if: ${{ matrix.os != 'ubuntu-latest' && matrix.java != '11' }}
4851
run: echo 'ARG_LINE=-D"excludedGroups=TestcontainersTests,RequireIllegalAccess"' >> $GITHUB_ENV
49-
- name: Set env command line option
50-
if: ${{ matrix.os == 'ubuntu-latest' }}
51-
run: echo 'ENV_GITHUB="-Denv.GITHUB"' >> $GITHUB_ENV
52+
- name: Active Profiles
53+
run: ./mvnw help:active-profiles
5254
- name: Test with Maven
5355
if: ${{ matrix.os != 'windows-latest' }}
54-
run: ./mvnw test -B -D"license.skip=true" -D"jacoco.skip=true" $ENV_GITHUB $ARG_LINE
56+
run: ./mvnw test -B -D"license.skip=true" -D"jacoco.skip=true" $ARG_LINE
5557
- name: Test with Maven
5658
if: ${{ matrix.os == 'windows-latest' && matrix.java == '11' }}
5759
run: ./mvnw test -B -D"license.skip=true" -D"jacoco.skip=true" -D"argLine=--illegal-access=permit"

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ derby.log
1616
/bin/
1717
.mvn/wrapper/maven-wrapper.jar
1818
.sts4-cache/
19+
*.releaseBackup

.mvn/maven.config

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
-Daether.checksums.algorithms=SHA-512,SHA-256,SHA-1,MD5 --no-transfer-progress
1+
-Daether.checksums.algorithms=SHA-512,SHA-256,SHA-1,MD5
2+
--no-transfer-progress

.mvn/wrapper/maven-wrapper.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
# "License"); you may not use this file except in compliance
77
# with the License. You may obtain a copy of the License at
88
#
9-
# https://www.apache.org/licenses/LICENSE-2.0
9+
# http://www.apache.org/licenses/LICENSE-2.0
1010
#
1111
# Unless required by applicable law or agreed to in writing,
1212
# software distributed under the License is distributed on an
1313
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
1414
# KIND, either express or implied. See the License for the
1515
# specific language governing permissions and limitations
1616
# under the License.
17-
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
18-
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
17+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.1/apache-maven-3.9.1-bin.zip
18+
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

README.md

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,54 @@ Essentials
2121
* [See the docs](https://mybatis.org/mybatis-3)
2222
* [Download Latest](https://github.com/mybatis/mybatis-3/releases)
2323
* [Download Snapshot](https://oss.sonatype.org/content/repositories/snapshots/org/mybatis/mybatis/)
24+
25+
Contributions
26+
-------------
27+
28+
Mybatis-core is now being auto formatted. Given nature of some code logic with mybatis, it is more appropriate to force a formatting structure manually for snippets such as sql statements. To do so, add following blocks around code.
29+
30+
- ```// @formatter:off``` to start the block of unformatted code
31+
- ```// @formatter:on``` to end the block of unformatted code
32+
33+
If comment sections need same behaviour such as javadocs, note that the entire block must be around entire comment as direct usage does not properly indicate that formatter treats it all as one comment block regardless.
34+
35+
Tests
36+
-----
37+
38+
Mybatis-3 code runs more expressive testing depending on jdk usage and platform.
39+
40+
By default, we set ```<excludedGroups>TestcontainersTests</excludedGroups>``` which will exclude a subset of tests with @Tag('TestcontainersTests'). Further, if pre jdk 16, we will further exclude record classes from executions further reducing tests.
41+
42+
When using jdk 16+, we adjust the rule to ```<excludedGroups>TestcontainersTests,RequireIllegalAccess</excludedGroups>```.
43+
44+
When we run on ci platform, we further make adjustments as needed. See [here](.github/workflows/ci.yaml) for details.
45+
46+
As of 2/20/2023, using combined system + jdk will result in given number of tests ran. This will change as tests are added or removed over time.
47+
48+
without adjusting settings (ie use as is, platform does not matter)
49+
50+
- any OS + jdk 11 = 1730 tests
51+
- any OS + jdk 17 = 1710 tests
52+
- any OS + jdk 19 = 1710 tests
53+
- any OS + jdk 20 = 1710 tests
54+
- any OS + jdk 21 = 1710 tests
55+
56+
our adjustments for GH actions where platform does matter
57+
58+
- windows + jdk 11 = 1730 tests
59+
- windows + jdk 17 = 1710 tests
60+
- windows + jdk 19 = 1710 tests
61+
- windows + jdk 20 = 1710 tests
62+
- windows + jdk 21 = 1710 tests
63+
64+
- linux + jdk 11 = 1765 tests
65+
- linux + jdk 17 = 1745 tests
66+
- linux + jdk 19 = 1745 tests
67+
- linux + jdk 20 = 1745 tests
68+
- linux + jdk 21 = 1745 tests
69+
70+
- mac + jdk 11 = 1730 tests
71+
- mac + jdk 17 = 1710 tests
72+
- mac + jdk 19 = 1710 tests
73+
- mac + jdk 20 = 1710 tests
74+
- mac + jdk 21 = 1710 tests

format.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
4+
Copyright 2009-2023 the original author or authors.
5+
6+
Licensed under the Apache License, Version 2.0 (the "License");
7+
you may not use this file except in compliance with the License.
8+
You may obtain a copy of the License at
9+
10+
https://www.apache.org/licenses/LICENSE-2.0
11+
12+
Unless required by applicable law or agreed to in writing, software
13+
distributed under the License is distributed on an "AS IS" BASIS,
14+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15+
See the License for the specific language governing permissions and
16+
limitations under the License.
17+
18+
-->
19+
<!DOCTYPE Format>
20+
<Format>
21+
<!-- Dummy format file -->
22+
</Format>

0 commit comments

Comments
 (0)