Skip to content

Commit 8db58a8

Browse files
committed
Remove renderer factory
It didn't reduce the Sonar cycles, and added unnecessary complexity
1 parent 99669ab commit 8db58a8

19 files changed

+124
-212
lines changed

src/main/java/org/mybatis/dynamic/sql/delete/DeleteModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import org.mybatis.dynamic.sql.common.CommonBuilder;
2424
import org.mybatis.dynamic.sql.common.OrderByModel;
2525
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
26+
import org.mybatis.dynamic.sql.delete.render.DeleteRenderer;
2627
import org.mybatis.dynamic.sql.delete.render.DeleteStatementProvider;
27-
import org.mybatis.dynamic.sql.render.RendererFactory;
2828
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2929
import org.mybatis.dynamic.sql.where.EmbeddedWhereModel;
3030

@@ -71,8 +71,10 @@ public StatementConfiguration statementConfiguration() {
7171

7272
@NotNull
7373
public DeleteStatementProvider render(RenderingStrategy renderingStrategy) {
74-
return RendererFactory.createDeleteRenderer(this)
75-
.render(renderingStrategy);
74+
return DeleteRenderer.withDeleteModel(this)
75+
.withRenderingStrategy(renderingStrategy)
76+
.build()
77+
.render();
7678
}
7779

7880
public static Builder withTable(SqlTable table) {

src/main/java/org/mybatis/dynamic/sql/insert/BatchInsertModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
import org.jetbrains.annotations.NotNull;
2121
import org.mybatis.dynamic.sql.insert.render.BatchInsert;
22-
import org.mybatis.dynamic.sql.render.RendererFactory;
22+
import org.mybatis.dynamic.sql.insert.render.BatchInsertRenderer;
2323
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2424
import org.mybatis.dynamic.sql.util.Validator;
2525

@@ -33,8 +33,10 @@ private BatchInsertModel(Builder<T> builder) {
3333

3434
@NotNull
3535
public BatchInsert<T> render(RenderingStrategy renderingStrategy) {
36-
return RendererFactory.createBatchInsertRenderer(this)
37-
.render(renderingStrategy);
36+
return BatchInsertRenderer.withBatchInsertModel(this)
37+
.withRenderingStrategy(renderingStrategy)
38+
.build()
39+
.render();
3840
}
3941

4042
public static <T> Builder<T> withRecords(Collection<T> records) {

src/main/java/org/mybatis/dynamic/sql/insert/GeneralInsertModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import org.jetbrains.annotations.NotNull;
2424
import org.mybatis.dynamic.sql.SqlTable;
2525
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
26+
import org.mybatis.dynamic.sql.insert.render.GeneralInsertRenderer;
2627
import org.mybatis.dynamic.sql.insert.render.GeneralInsertStatementProvider;
27-
import org.mybatis.dynamic.sql.render.RendererFactory;
2828
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2929
import org.mybatis.dynamic.sql.util.AbstractColumnMapping;
3030
import org.mybatis.dynamic.sql.util.Validator;
@@ -56,8 +56,10 @@ public StatementConfiguration statementConfiguration() {
5656

5757
@NotNull
5858
public GeneralInsertStatementProvider render(RenderingStrategy renderingStrategy) {
59-
return RendererFactory.createGeneralInsertRenderer(this)
60-
.render(renderingStrategy);
59+
return GeneralInsertRenderer.withInsertModel(this)
60+
.withRenderingStrategy(renderingStrategy)
61+
.build()
62+
.render();
6163
}
6264

6365
public static class Builder {

src/main/java/org/mybatis/dynamic/sql/insert/InsertModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222

2323
import org.jetbrains.annotations.NotNull;
2424
import org.mybatis.dynamic.sql.SqlTable;
25+
import org.mybatis.dynamic.sql.insert.render.InsertRenderer;
2526
import org.mybatis.dynamic.sql.insert.render.InsertStatementProvider;
26-
import org.mybatis.dynamic.sql.render.RendererFactory;
2727
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2828
import org.mybatis.dynamic.sql.util.AbstractColumnMapping;
2929
import org.mybatis.dynamic.sql.util.Validator;
@@ -54,8 +54,10 @@ public SqlTable table() {
5454

5555
@NotNull
5656
public InsertStatementProvider<T> render(RenderingStrategy renderingStrategy) {
57-
return RendererFactory.createInsertRenderer(this)
58-
.render(renderingStrategy);
57+
return InsertRenderer.withInsertModel(this)
58+
.withRenderingStrategy(renderingStrategy)
59+
.build()
60+
.render();
5961
}
6062

6163
public static <T> Builder<T> withRow(T row) {

src/main/java/org/mybatis/dynamic/sql/insert/InsertSelectModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import org.jetbrains.annotations.NotNull;
2222
import org.mybatis.dynamic.sql.SqlTable;
2323
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
24+
import org.mybatis.dynamic.sql.insert.render.InsertSelectRenderer;
2425
import org.mybatis.dynamic.sql.insert.render.InsertSelectStatementProvider;
25-
import org.mybatis.dynamic.sql.render.RendererFactory;
2626
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2727
import org.mybatis.dynamic.sql.select.SelectModel;
2828

@@ -57,8 +57,10 @@ public StatementConfiguration statementConfiguration() {
5757

5858
@NotNull
5959
public InsertSelectStatementProvider render(RenderingStrategy renderingStrategy) {
60-
return RendererFactory.createInsertSelectRenderer(this)
61-
.render(renderingStrategy);
60+
return InsertSelectRenderer.withInsertSelectModel(this)
61+
.withRenderingStrategy(renderingStrategy)
62+
.build()
63+
.render();
6264
}
6365

6466
public static Builder withTable(SqlTable table) {

src/main/java/org/mybatis/dynamic/sql/insert/MultiRowInsertModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
import java.util.Collection;
1919

2020
import org.jetbrains.annotations.NotNull;
21+
import org.mybatis.dynamic.sql.insert.render.MultiRowInsertRenderer;
2122
import org.mybatis.dynamic.sql.insert.render.MultiRowInsertStatementProvider;
22-
import org.mybatis.dynamic.sql.render.RendererFactory;
2323
import org.mybatis.dynamic.sql.render.RenderingStrategy;
2424
import org.mybatis.dynamic.sql.util.Validator;
2525

@@ -33,8 +33,10 @@ private MultiRowInsertModel(Builder<T> builder) {
3333

3434
@NotNull
3535
public MultiRowInsertStatementProvider<T> render(RenderingStrategy renderingStrategy) {
36-
return RendererFactory.createMultiRowInsertRenderer(this)
37-
.render(renderingStrategy);
36+
return MultiRowInsertRenderer.withMultiRowInsertModel(this)
37+
.withRenderingStrategy(renderingStrategy)
38+
.build()
39+
.render();
3840
}
3941

4042
public static <T> Builder<T> withRecords(Collection<T> records) {

src/main/java/org/mybatis/dynamic/sql/insert/render/InsertSelectRenderer.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import org.mybatis.dynamic.sql.SqlColumn;
2424
import org.mybatis.dynamic.sql.insert.InsertColumnListModel;
2525
import org.mybatis.dynamic.sql.insert.InsertSelectModel;
26-
import org.mybatis.dynamic.sql.render.RendererFactory;
2726
import org.mybatis.dynamic.sql.render.RenderingContext;
2827
import org.mybatis.dynamic.sql.render.RenderingStrategy;
28+
import org.mybatis.dynamic.sql.select.render.SubQueryRenderer;
2929
import org.mybatis.dynamic.sql.util.FragmentAndParameters;
3030

3131
public class InsertSelectRenderer {
@@ -45,9 +45,11 @@ public InsertSelectStatementProvider render() {
4545
String columnsPhrase = calculateColumnsPhrase();
4646
String prefix = statementStart + spaceAfter(columnsPhrase);
4747

48-
FragmentAndParameters fragmentAndParameters = RendererFactory.createSubQueryRenderer(model.selectModel(),
49-
prefix, "") //$NON-NLS-1$
50-
.render(renderingContext);
48+
FragmentAndParameters fragmentAndParameters = SubQueryRenderer.withSelectModel(model.selectModel())
49+
.withRenderingContext(renderingContext)
50+
.withPrefix(prefix)
51+
.build()
52+
.render();
5153

5254
return DefaultGeneralInsertStatementProvider.withInsertStatement(fragmentAndParameters.fragment())
5355
.withParameters(fragmentAndParameters.parameters())

src/main/java/org/mybatis/dynamic/sql/render/Renderer.java

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/main/java/org/mybatis/dynamic/sql/render/RendererFactory.java

Lines changed: 0 additions & 125 deletions
This file was deleted.

src/main/java/org/mybatis/dynamic/sql/select/MultiSelectModel.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import java.util.stream.Stream;
2222

2323
import org.jetbrains.annotations.NotNull;
24-
import org.mybatis.dynamic.sql.render.RendererFactory;
2524
import org.mybatis.dynamic.sql.render.RenderingStrategy;
25+
import org.mybatis.dynamic.sql.select.render.MultiSelectRenderer;
2626
import org.mybatis.dynamic.sql.select.render.SelectStatementProvider;
2727
import org.mybatis.dynamic.sql.util.Validator;
2828

@@ -47,8 +47,10 @@ public Stream<UnionQuery> unionQueries() {
4747

4848
@NotNull
4949
public SelectStatementProvider render(RenderingStrategy renderingStrategy) {
50-
return RendererFactory.createMultiSelectRenderer(this)
51-
.render(renderingStrategy);
50+
return MultiSelectRenderer.withMultiSelectModel(this)
51+
.withRenderingStrategy(renderingStrategy)
52+
.build()
53+
.render();
5254
}
5355

5456
public static class Builder extends AbstractBuilder<Builder> {

src/main/java/org/mybatis/dynamic/sql/select/SelectModel.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import java.util.stream.Stream;
2222

2323
import org.jetbrains.annotations.NotNull;
24-
import org.mybatis.dynamic.sql.render.RendererFactory;
2524
import org.mybatis.dynamic.sql.render.RenderingStrategy;
25+
import org.mybatis.dynamic.sql.select.render.SelectRenderer;
2626
import org.mybatis.dynamic.sql.select.render.SelectStatementProvider;
2727
import org.mybatis.dynamic.sql.util.Validator;
2828

@@ -41,7 +41,10 @@ public Stream<QueryExpressionModel> queryExpressions() {
4141

4242
@NotNull
4343
public SelectStatementProvider render(RenderingStrategy renderingStrategy) {
44-
return RendererFactory.createSelectRenderer(this).render(renderingStrategy);
44+
return SelectRenderer.withSelectModel(this)
45+
.withRenderingStrategy(renderingStrategy)
46+
.build()
47+
.render();
4548
}
4649

4750
public static Builder withQueryExpressions(List<QueryExpressionModel> queryExpressions) {

0 commit comments

Comments
 (0)