Skip to content

Commit 969e50d

Browse files
steffenlarsenjiezzhang
authored andcommitted
[SYCL] Make DeviceGlobal tests unsupported rather than xfail (intel#1235)
To avoid problems when drivers for CPU and accelerators add support for device_global this commit changes the XFAIL to UNSUPPORTED until they are known to be supported in CI. Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 486136d commit 969e50d

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

SYCL/DeviceGlobal/device_global_arrow.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
1212
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
1313
//
14-
// Currently fails for CPUs due to missing support for the SPIR-V extension.
15-
// Currently crashes on accelerators.
16-
// XFAIL: cpu, accelerator
14+
// CPU and accelerators are not currently guaranteed to support the required
15+
// extensions they are disabled until they are.
16+
// UNSUPPORTED: cpu, accelerator
1717
//
1818
// Tests operator-> on device_global.
1919
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so

SYCL/DeviceGlobal/device_global_device_only.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
1212
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
1313
//
14-
// Currently fails for CPUs due to missing support for the SPIR-V extension.
15-
// Currently crashes on accelerators.
16-
// XFAIL: cpu, accelerator
14+
// CPU and accelerators are not currently guaranteed to support the required
15+
// extensions they are disabled until they are.
16+
// UNSUPPORTED: cpu, accelerator
1717
//
1818
// Tests basic device_global access through device kernels.
1919
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so

SYCL/DeviceGlobal/device_global_operator_passthrough.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
1212
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
1313
//
14-
// Currently fails for CPUs due to missing support for the SPIR-V extension.
15-
// Currently crashes on accelerators.
16-
// XFAIL: cpu, accelerator
14+
// CPU and accelerators are not currently guaranteed to support the required
15+
// extensions they are disabled until they are.
16+
// UNSUPPORTED: cpu, accelerator
1717
//
1818
// Tests the passthrough of operators on device_global.
1919
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so

SYCL/DeviceGlobal/device_global_subscript.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
1212
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
1313
//
14-
// Currently fails for CPUs due to missing support for the SPIR-V extension.
15-
// Currently crashes on accelerators.
16-
// XFAIL: cpu, accelerator
14+
// CPU and accelerators are not currently guaranteed to support the required
15+
// extensions they are disabled until they are.
16+
// UNSUPPORTED: cpu, accelerator
1717
//
1818
// Tests operator[] on device_global.
1919
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so

0 commit comments

Comments
 (0)