Skip to content

Commit cc8ee1e

Browse files
author
Pavel Samolysov
authored
[SYCL] Use the sycl:: namespace instead of cl::sycl:: one (intel#749)
* [SYCL] Use the sycl:: namespace instead of cl::sycl:: one Moving from SYCL 1.2.1 to SYCL 2020 should change two things: - The cl::sycl namespace should be sycl:: instead and come in via sycl/sycl.hpp - sycl::access::target should be sycl::target because the former is deprecated Signed-off-by: Pavel Samolysov <[email protected]> * [SYCL][NFC] Fix formatting issues Signed-off-by: Pavel Samolysov <[email protected]>
1 parent 47a4b5b commit cc8ee1e

File tree

1 file changed

+46
-51
lines changed

1 file changed

+46
-51
lines changed

SYCL/Basic/accessor/accessor.cpp

Lines changed: 46 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
1212
//
1313
//===----------------------------------------------------------------------===//
14-
#include <CL/sycl.hpp>
1514
#include <cassert>
15+
#include <sycl/sycl.hpp>
1616

1717
struct IdxID1 {
1818
int x;
@@ -31,8 +31,9 @@ struct IdxID3 {
3131
};
3232

3333
template <typename T>
34-
using AccAlias = cl::sycl::accessor<T, 1, cl::sycl::access::mode::write,
35-
cl::sycl::access::target::device>;
34+
using AccAlias =
35+
sycl::accessor<T, 1, sycl::access::mode::write, sycl::target::device>;
36+
3637
template <typename T> struct InheritedAccessor : public AccAlias<T> {
3738

3839
using AccAlias<T>::AccAlias;
@@ -66,9 +67,9 @@ int main() {
6667
int dst[2];
6768

6869
sycl::buffer<int, 1> buf_src(src, sycl::range<1>(2),
69-
{cl::sycl::property::buffer::use_host_ptr()});
70+
{sycl::property::buffer::use_host_ptr()});
7071
sycl::buffer<int, 1> buf_dst(dst, sycl::range<1>(2),
71-
{cl::sycl::property::buffer::use_host_ptr()});
72+
{sycl::property::buffer::use_host_ptr()});
7273

7374
sycl::id<1> id1(1);
7475
auto acc_src = buf_src.get_access<sycl::access::mode::read>();
@@ -122,7 +123,7 @@ int main() {
122123
sycl::queue Queue;
123124

124125
sycl::buffer<int, 1> buf(&data, sycl::range<1>(1),
125-
{cl::sycl::property::buffer::use_host_ptr()});
126+
{sycl::property::buffer::use_host_ptr()});
126127

127128
Queue.submit([&](sycl::handler &cgh) {
128129
auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
@@ -144,7 +145,7 @@ int main() {
144145
{
145146
sycl::range<2> Range(2, 3);
146147
sycl::buffer<int, 2> buf((int *)array, Range,
147-
{cl::sycl::property::buffer::use_host_ptr()});
148+
{sycl::property::buffer::use_host_ptr()});
148149

149150
Queue.submit([&](sycl::handler &cgh) {
150151
auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
@@ -169,18 +170,17 @@ int main() {
169170
// Device accessor with 2-dimensional subscript operators for atomic accessor
170171
// check compile error
171172
{
172-
cl::sycl::queue queue;
173+
sycl::queue queue;
173174
if (!queue.is_host()) {
174-
cl::sycl::range<2> range(1, 1);
175+
sycl::range<2> range(1, 1);
175176
int Arr[] = {2};
176177
{
177-
cl::sycl::buffer<int, 1> Buf(Arr, 1);
178-
queue.submit([&](cl::sycl::handler &cgh) {
179-
auto acc =
180-
cl::sycl::accessor<int, 2, cl::sycl::access::mode::atomic,
181-
cl::sycl::access::target::local>(range, cgh);
178+
sycl::buffer<int, 1> Buf(Arr, 1);
179+
queue.submit([&](sycl::handler &cgh) {
180+
auto acc = sycl::accessor<int, 2, sycl::access::mode::atomic,
181+
sycl::target::local>(range, cgh);
182182
cgh.parallel_for<class dim2_subscr_atomic>(
183-
cl::sycl::nd_range<2>{range, range}, [=](cl::sycl::nd_item<2>) {
183+
sycl::nd_range<2>{range, range}, [=](sycl::nd_item<2>) {
184184
sycl::atomic<int, sycl::access::address_space::local_space>
185185
value = acc[0][0];
186186
});
@@ -197,7 +197,7 @@ int main() {
197197
{
198198
sycl::range<3> Range(2, 3, 4);
199199
sycl::buffer<int, 3> buf((int *)array, Range,
200-
{cl::sycl::property::buffer::use_host_ptr()});
200+
{sycl::property::buffer::use_host_ptr()});
201201

202202
Queue.submit([&](sycl::handler &cgh) {
203203
auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
@@ -225,23 +225,22 @@ int main() {
225225

226226
// Local accessor
227227
{
228-
cl::sycl::queue queue;
228+
sycl::queue queue;
229229

230230
constexpr int dims = 1;
231231

232232
using data_loc = int;
233-
constexpr auto mode_loc = cl::sycl::access::mode::read_write;
234-
constexpr auto target_loc = cl::sycl::target::local;
235-
const auto range_loc = cl::sycl::range<1>(1);
233+
constexpr auto mode_loc = sycl::access::mode::read_write;
234+
constexpr auto target_loc = sycl::target::local;
235+
const auto range_loc = sycl::range<1>(1);
236236

237237
{
238-
queue.submit([&](cl::sycl::handler &cgh) {
239-
auto properties = cl::sycl::property_list{};
238+
queue.submit([&](sycl::handler &cgh) {
239+
auto properties = sycl::property_list{};
240240

241-
auto acc_loc_p =
242-
cl::sycl::accessor<data_loc, dims, mode_loc, target_loc>(
243-
range_loc, cgh, properties);
244-
auto acc_loc = cl::sycl::accessor<data_loc, dims, mode_loc, target_loc>(
241+
auto acc_loc_p = sycl::accessor<data_loc, dims, mode_loc, target_loc>(
242+
range_loc, cgh, properties);
243+
auto acc_loc = sycl::accessor<data_loc, dims, mode_loc, target_loc>(
245244
range_loc, cgh);
246245

247246
cgh.single_task<class loc_img_acc>([=]() {});
@@ -266,7 +265,7 @@ int main() {
266265
for (int i = 0; i != 3; ++i)
267266
assert(host_acc[i] == 42);
268267

269-
} catch (cl::sycl::exception e) {
268+
} catch (sycl::exception e) {
270269
std::cout << "SYCL exception caught: " << e.what();
271270
return 1;
272271
}
@@ -286,7 +285,7 @@ int main() {
286285
});
287286

288287
auto host_acc = buf.get_access<sycl::access::mode::discard_read_write>();
289-
} catch (cl::sycl::exception e) {
288+
} catch (sycl::exception e) {
290289
std::cout << "SYCL exception caught: " << e.what();
291290
return 1;
292291
}
@@ -299,7 +298,7 @@ int main() {
299298
int array[10] = {0};
300299
{
301300
sycl::buffer<int, 1> buf((int *)array, sycl::range<1>(10),
302-
{cl::sycl::property::buffer::use_host_ptr()});
301+
{sycl::property::buffer::use_host_ptr()});
303302
queue.submit([&](sycl::handler &cgh) {
304303
auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
305304
auto acc_wrapped = AccWrapper<decltype(acc)>{acc};
@@ -330,9 +329,9 @@ int main() {
330329
int array2[10] = {0};
331330
{
332331
sycl::buffer<int, 1> buf1((int *)array1, sycl::range<1>(10),
333-
{cl::sycl::property::buffer::use_host_ptr()});
332+
{sycl::property::buffer::use_host_ptr()});
334333
sycl::buffer<int, 1> buf2((int *)array2, sycl::range<1>(10),
335-
{cl::sycl::property::buffer::use_host_ptr()});
334+
{sycl::property::buffer::use_host_ptr()});
336335
queue.submit([&](sycl::handler &cgh) {
337336
auto acc1 = buf1.get_access<sycl::access::mode::read_write>(cgh);
338337
auto acc2 = buf2.get_access<sycl::access::mode::read_write>(cgh);
@@ -371,7 +370,7 @@ int main() {
371370
int array[10] = {0};
372371
{
373372
sycl::buffer<int, 1> buf((int *)array, sycl::range<1>(10),
374-
{cl::sycl::property::buffer::use_host_ptr()});
373+
{sycl::property::buffer::use_host_ptr()});
375374
queue.submit([&](sycl::handler &cgh) {
376375
auto acc = buf.get_access<sycl::access::mode::read_write>(cgh);
377376
auto acc_wrapped = AccWrapper<decltype(acc)>{acc};
@@ -416,7 +415,7 @@ int main() {
416415
for (int i = 0; i != 3; ++i)
417416
assert(host_acc[i] == 42);
418417

419-
} catch (cl::sycl::exception e) {
418+
} catch (sycl::exception e) {
420419
std::cout << "SYCL exception caught: " << e.what();
421420
return 1;
422421
}
@@ -431,7 +430,7 @@ int main() {
431430
sycl::queue queue;
432431
queue.submit([&](sycl::handler &cgh) {
433432
sycl::accessor<int, 0, sycl::access::mode::read_write,
434-
sycl::access::target::device>
433+
sycl::target::device>
435434
B(b, cgh);
436435
cgh.single_task<class acc_with_zero_dim>([=]() {
437436
auto B2 = B;
@@ -463,13 +462,13 @@ int main() {
463462
sycl::queue queue;
464463
queue.submit([&](sycl::handler &cgh) {
465464
sycl::accessor<int, 0, sycl::access::mode::read_write,
466-
sycl::access::target::device>
465+
sycl::target::device>
467466
acc1(buf1, cgh);
468467
sycl::accessor<int, 1, sycl::access::mode::read_write,
469-
sycl::access::target::device>
468+
sycl::target::device>
470469
acc2(buf2, cgh);
471470
sycl::accessor<int, 1, sycl::access::mode::read_write,
472-
sycl::access::target::device>
471+
sycl::target::device>
473472
acc3(buf3, cgh, sycl::range<1>(1));
474473
cgh.single_task<class acc_alloc_buf>([=]() {
475474
acc1 *= 2;
@@ -478,14 +477,11 @@ int main() {
478477
});
479478
});
480479

481-
sycl::accessor<int, 0, sycl::access::mode::read,
482-
sycl::access::target::host_buffer>
480+
sycl::accessor<int, 0, sycl::access::mode::read, sycl::target::host_buffer>
483481
acc4(buf1);
484-
sycl::accessor<int, 1, sycl::access::mode::read,
485-
sycl::access::target::host_buffer>
482+
sycl::accessor<int, 1, sycl::access::mode::read, sycl::target::host_buffer>
486483
acc5(buf2);
487-
sycl::accessor<int, 1, sycl::access::mode::read,
488-
sycl::access::target::host_buffer>
484+
sycl::accessor<int, 1, sycl::access::mode::read, sycl::target::host_buffer>
489485
acc6(buf3, sycl::range<1>(1));
490486

491487
assert(acc4 == 2);
@@ -506,10 +502,10 @@ int main() {
506502
sycl::queue queue;
507503
queue.submit([&](sycl::handler &cgh) {
508504
sycl::accessor<int, 1, sycl::access::mode::write,
509-
sycl::access::target::device>
505+
sycl::target::device>
510506
D(d, cgh);
511507
sycl::accessor<int, 1, sycl::access::mode::read,
512-
sycl::access::target::constant_buffer>
508+
sycl::target::constant_buffer>
513509
C(c, cgh);
514510

515511
cgh.single_task<class acc_with_const>([=]() { D[0] = C[0]; });
@@ -535,12 +531,11 @@ int main() {
535531
sycl::buffer<int, 1> d(&data, sycl::range<1>(1));
536532
sycl::buffer<int, 1> c(&cnst, sycl::range<1>(1));
537533

538-
sycl::accessor<int, 1, sycl::access::mode::write,
539-
sycl::access::target::device,
534+
sycl::accessor<int, 1, sycl::access::mode::write, sycl::target::device,
540535
sycl::access::placeholder::true_t>
541536
D(d);
542537
sycl::accessor<int, 1, sycl::access::mode::read,
543-
sycl::access::target::constant_buffer,
538+
sycl::target::constant_buffer,
544539
sycl::access::placeholder::true_t>
545540
C(c);
546541

@@ -574,10 +569,10 @@ int main() {
574569
sycl::queue queue;
575570
queue.submit([&](sycl::handler &cgh) {
576571
sycl::accessor<int, 1, sycl::access::mode::write,
577-
sycl::access::target::device>
572+
sycl::target::device>
578573
AccA(A, cgh);
579574
sycl::accessor<int, 1, sycl::access::mode::read,
580-
sycl::access::target::constant_buffer>
575+
sycl::target::constant_buffer>
581576
AccB(B, cgh);
582577
InheritedAccessor<int> AccC(C, cgh);
583578
cgh.single_task<class acc_base>(
@@ -609,7 +604,7 @@ int main() {
609604
sycl::queue queue;
610605
queue.submit([&](sycl::handler &cgh) {
611606
sycl::accessor<int, 1, sycl::access::mode::read_write,
612-
sycl::access::target::device>
607+
sycl::target::device>
613608
B(b, cgh);
614609
auto B1 = b1.template get_access<sycl::access::mode::read_write>(cgh);
615610

0 commit comments

Comments
 (0)