Skip to content

Commit d4ce9e3

Browse files
dongkyunahn-intelbb-sycl
authored andcommitted
[SYCL][ESIMD][EMU] Removing 'XFAIL' markings for 'single_task' tests (intel#910)
* [SYCL][ESIMD][EMU] Removing 'XFAIL' markings for 'single_task' tests - 'single_task()' is enabled for ESIMD_EMULATOR backend in intel/llvm * Comment update for newly discovered failure after 'single_task()' enabled * Preparing enabling ESIMD_EMULATOR during CI
1 parent 48e530c commit d4ce9e3

File tree

7 files changed

+20
-12
lines changed

7 files changed

+20
-12
lines changed

SYCL/ESIMD/api/esimd_bit_ops.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
//===----------------------------------------------------------------------===//
88
// REQUIRES: gpu
99
// UNSUPPORTED: cuda || hip
10-
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
11-
// XFAIL: esimd_emulator
1210
// RUN: %clangxx -fsycl %s -fsycl-device-code-split=per_kernel -o %t.out
1311
// RUN: %GPU_RUN_PLACEHOLDER %t.out
1412
//

SYCL/ESIMD/api/esimd_pack_unpack_mask.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
// UNSUPPORTED: cuda || hip
1010
<<<<<<< HEAD
1111
<<<<<<< HEAD
12+
<<<<<<< HEAD
1213
=======
1314
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
1415
// XFAIL: esimd_emulator
@@ -20,6 +21,10 @@
2021
>>>>>>> 05909cd65 (Disable esimd_pack_unpack_mask test on OpenCL (#902))
2122
=======
2223
>>>>>>> e3ff34842 ([ESIMD] Size correction for array containing result values (#913))
24+
=======
25+
// TODO: esimd_emulator fails due to a bug in __esimd_pack_mask() intrinsic
26+
// XFAIL: esimd_emulator
27+
>>>>>>> 1947aed85 ([SYCL][ESIMD][EMU] Removing 'XFAIL' markings for 'single_task' tests (#910))
2328
// RUN: %clangxx -fsycl %s -fsycl-device-code-split=per_kernel -o %t.out
2429
// RUN: %GPU_RUN_PLACEHOLDER %t.out
2530
//

SYCL/ESIMD/api/esimd_rgba_smoke.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
// UNSUPPORTED: cuda || hip
1010
<<<<<<< HEAD
1111
<<<<<<< HEAD
12+
<<<<<<< HEAD
1213
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
1314
// XFAIL: esimd_emulator
1415
=======
@@ -17,6 +18,8 @@
1718
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
1819
// XFAIL: esimd_emulator
1920
>>>>>>> b3d790428 ([SYCL][ESIMD][EMU] XFAIL for 'SYCL/ESIMD/api/esimd_rgba_smoke.cpp' (#840))
21+
=======
22+
>>>>>>> 1947aed85 ([SYCL][ESIMD][EMU] Removing 'XFAIL' markings for 'single_task' tests (#910))
2023
// RUN: %clangxx -fsycl %s -o %t.out
2124
// RUN: %GPU_RUN_PLACEHOLDER %t.out
2225

SYCL/ESIMD/api/replicate_smoke.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
// UNSUPPORTED: cuda || hip
1010
<<<<<<< HEAD
1111
<<<<<<< HEAD
12+
<<<<<<< HEAD
1213
// TODO: esimd_emulator fails due to unimplemented 'half' type
1314
// XFAIL: esimd_emulator
1415
=======
@@ -17,6 +18,8 @@
1718
// TODO: esimd_emulator fails due to unimplemented 'half' type
1819
// XFAIL: esimd_emulator
1920
>>>>>>> d98407d06 ([SYCL][ESIMD][EMU] Marking ESIMD kernels for esimd_emulator backend (#751))
21+
=======
22+
>>>>>>> 1947aed85 ([SYCL][ESIMD][EMU] Removing 'XFAIL' markings for 'single_task' tests (#910))
2023
// RUN: %clangxx -fsycl %s -o %t.out
2124
// RUN: %GPU_RUN_PLACEHOLDER %t.out
2225
//

SYCL/ESIMD/api/svm_gather_scatter.cpp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,15 @@ int main(void) {
100100
Pass &= test<int32_t, 16>(Q);
101101
Pass &= test<int32_t, 32>(Q);
102102

103-
Pass &= test<half, 1>(Q);
104-
Pass &= test<half, 2>(Q);
105-
Pass &= test<half, 4>(Q);
106-
Pass &= test<half, 8>(Q);
107-
Pass &= test<half, 16>(Q);
108-
Pass &= test<half, 32>(Q);
103+
if (Q.get_backend() != cl::sycl::backend::ext_intel_esimd_emulator) {
104+
/// TODO: Enable 'half' type support for esimd_emulator
105+
Pass &= test<half, 1>(Q);
106+
Pass &= test<half, 2>(Q);
107+
Pass &= test<half, 4>(Q);
108+
Pass &= test<half, 8>(Q);
109+
Pass &= test<half, 16>(Q);
110+
Pass &= test<half, 32>(Q);
111+
}
109112

110113
std::cout << (Pass ? "Test Passed\n" : "Test FAILED\n");
111114
return Pass ? 0 : 1;

SYCL/ESIMD/printf.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
// REQUIRES: gpu
1010
// UNSUPPORTED: cuda || hip
1111
// CUDA and HIP don't support printf.
12-
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
13-
// XFAIL: esimd_emulator
1412
//
1513
// RUN: %clangxx -fsycl %s -o %t.out
1614
// RUN: %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER

SYCL/ESIMD/regression/variable_gather_mask.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
//===----------------------------------------------------------------------===//
88
// REQUIRES: gpu
99
// UNSUPPORTED: cuda || hip
10-
// TODO: esimd_emulator fails due to unimplemented 'single_task()' method
11-
// XFAIL: esimd_emulator
1210
// RUN: %clangxx -fsycl %s -o %t.out
1311
// RUN: %GPU_RUN_PLACEHOLDER %t.out
1412
//

0 commit comments

Comments
 (0)