Test that exception is thrown for over 64K parameters.

Author: bgrainger

tests/SideBySide/PreparedCommandTests.cs

@@ -243,40 +243,67 @@ public void ThrowsIfTooManyUnnamedParametersUsed()
 		[InlineData(65535)]
 		public void ParametersAreBound(int parameterCount)
 		{
-			using (var connection = CreatePrepareConnection())
+			using (var connection = CreateConnectionWithTableOfIntegers())
+			using (var cmd = CreateCommandWithParameters(connection, parameterCount))
 			{
-				connection.Execute(@"drop table if exists prepared_command_test; create table prepared_command_test(value int not null); insert into prepared_command_test(value) values (1),(2),(3),(4),(5),(6),(7),(8),(9),(10);");
+				cmd.Prepare();
 
-				using (var cmd = connection.CreateCommand())
+				using (var reader = cmd.ExecuteReader())
 				{
-					var sql = new StringBuilder("select value from prepared_command_test where value in (");
-					for (int parameterIndex = 1; parameterIndex <= parameterCount; parameterIndex++)
+					for (var i = 1; i <= Math.Min(parameterCount, 10); i++)
 					{
-						var parameterName = "p" + parameterIndex;
-						cmd.Parameters.AddWithValue(parameterName, parameterIndex);
-						if (parameterIndex > 1)
-							sql.Append(",");
-						sql.Append("@");
-						sql.Append(parameterName);
+						Assert.True(reader.Read());
+						Assert.Equal(i, reader.GetInt32(0));
 					}
-					sql.Append(") order by value;");
+					Assert.False(reader.Read());
+				}
+			}
+		}
 
-					cmd.CommandText = sql.ToString();
+		[Fact]
+		public void CannotUse64KParameters()
+		{
+			using (var connection = CreateConnectionWithTableOfIntegers())
+			using (var cmd = CreateCommandWithParameters(connection, 65536))
+			{
+				try
+				{
 					cmd.Prepare();
-
-					using (var reader = cmd.ExecuteReader())
-					{
-						for (var i = 1; i <= Math.Min(parameterCount, 10); i++)
-						{
-							Assert.True(reader.Read());
-							Assert.Equal(i, reader.GetInt32(0));
-						}
-						Assert.False(reader.Read());
-					}
+					Assert.False(true, "Exception wasn't thrown");
+				}
+				catch (MySqlException ex)
+				{
+					Assert.Equal(MySqlErrorCode.PreparedStatementManyParameters, (MySqlErrorCode) ex.Number);
 				}
 			}
 		}
 
+		private static MySqlConnection CreateConnectionWithTableOfIntegers()
+		{
+			var connection = CreatePrepareConnection();
+			connection.Execute(@"drop table if exists prepared_command_test; create table prepared_command_test(value int not null); insert into prepared_command_test(value) values (1),(2),(3),(4),(5),(6),(7),(8),(9),(10);");
+			return connection;
+		}
+
+		private static MySqlCommand CreateCommandWithParameters(MySqlConnection connection, int parameterCount)
+		{
+			var cmd = connection.CreateCommand();
+			var sql = new StringBuilder("select value from prepared_command_test where value in (");
+			for (int parameterIndex = 1; parameterIndex <= parameterCount; parameterIndex++)
+			{
+				var parameterName = "p" + parameterIndex;
+				cmd.Parameters.AddWithValue(parameterName, parameterIndex);
+				if (parameterIndex > 1)
+					sql.Append(",");
+				sql.Append("@");
+				sql.Append(parameterName);
+			}
+			sql.Append(") order by value;");
+
+			cmd.CommandText = sql.ToString();
+			return cmd;
+		}
+
 		public static IEnumerable<object[]> GetInsertAndQueryData()
 		{
 			foreach (var isPrepared in new[] { false, true })