Bug#35155005 Buffers for holding a key of 'MAX_KEY_SIZE' are allocated too small

The #define MAX_KEY_SIZE_IN_WORDS 1023 are used multiple places where
we need to define different kind of buffers for holding a tuple key.

Some places we define this buffer as an array of Uint64's, probably due
to a double word allignment were assumed to be more efficient when
accessing the key buffer.

As we right shifted-by-1 the MAX_KEY_SIZE_IN_WORDS when defining such
Uint64 arrays, *without* adding +1 to compensate for the alignment
truncation, the allocated Uint64 buffer ended up being a 'word' too
small to buffer a full MAX_KEY.

These Uint64 buffers where used for storing a key to calculate
a hash key - md5_hash() used to take a Uint64* aligned argument
for the value to be hashed.

This was changed by patch for Bug#35180841
    Remove requirement for md5_hash() input to be 8-byte aligned

Thus we can now define these buffers as Uint32[] instead.
Patch change these buffer definitions accordingly.

Change-Id: If5356bae4a3e997fdb09caa89fd3c3626b782d56

Author: Ole John Aske

storage/ndb/plugin/ha_ndbcluster.cc

@@ -7599,7 +7599,7 @@ NdbTransaction *ha_ndbcluster::start_transaction_row(
 
   Ndb *ndb = m_thd_ndb->ndb;
 
-  Uint64 tmp[(MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY) >> 1];
+  Uint32 tmp[MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY];
   char *buf = (char *)&tmp[0];
   trans =
       ndb->startTransaction(ndb_record, (const char *)record, buf, sizeof(tmp));
@@ -7627,7 +7627,7 @@ NdbTransaction *ha_ndbcluster::start_transaction_key(uint index_num,
   Ndb *ndb = m_thd_ndb->ndb;
   const NdbRecord *key_rec = m_index[index_num].ndb_unique_record_key;
 
-  Uint64 tmp[(MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY) >> 1];
+  Uint32 tmp[MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY];
   char *buf = (char *)&tmp[0];
   trans =
       ndb->startTransaction(key_rec, (const char *)key_data, buf, sizeof(tmp));
@@ -14775,7 +14775,7 @@ uint32 ha_ndbcluster::calculate_key_hash_value(Field **field_array) {
   struct Ndb::Key_part_ptr *key_data_ptr = &key_data[0];
   Uint32 i = 0;
   int ret_val;
-  Uint64 tmp[(MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY) >> 1];
+  Uint32 tmp[MAX_KEY_SIZE_IN_WORDS * MAX_XFRM_MULTIPLY];
   void *buf = (void *)&tmp[0];
   DBUG_TRACE;
 

storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp

@@ -17641,23 +17641,23 @@ Uint32
 Dblqh::readPrimaryKeys(Uint32 opPtrI, Uint32 *dst, bool xfrm_hash)
 {
   TcConnectionrecPtr regTcPtr;
-  Uint64 Tmp[MAX_KEY_SIZE_IN_WORDS >> 1];
+  Uint32 Tmp[MAX_KEY_SIZE_IN_WORDS];
 
   jamEntry();
   regTcPtr.i = opPtrI;
   ndbrequire(tcConnect_pool.getValidPtr(regTcPtr));
 
   const Uint32 tableId = regTcPtr.p->tableref;
   const Uint32 keyLen = regTcPtr.p->primKeyLen;
-  Uint32 *buf = xfrm_hash ? (Uint32*)Tmp : dst;
+  Uint32 *buf = xfrm_hash ? Tmp : dst;
 
   copy(buf, regTcPtr.p->keyInfoIVal);
 
   if (xfrm_hash)
   {
     jam();
     Uint32 keyPartLen[MAX_ATTRIBUTES_IN_INDEX];
-    return xfrm_key_hash(tableId, (Uint32*)Tmp, dst, ~0, keyPartLen);
+    return xfrm_key_hash(tableId, Tmp, dst, ~0, keyPartLen);
   }
   return keyLen;
 }