Bug#35598485 Fix RPATH for opentelemetry plugins

We already have cmake code to fix RPATH for the group_replication
plugin. Do the same thing for telemetry_client and
component_telemetry.

Also silence a message in opentelemetry cmake code:
without the proper <mode> the text ends up in stderr rather than stdout.

Change-Id: I923ae71fa0662ec72a0385c50be6972ade4f452b

Author: Tor Didriksen

cmake/component.cmake

@@ -89,6 +89,7 @@ MACRO(MYSQL_ADD_COMPONENT component_arg)
   ADD_DEPENDENCIES(${target} GenError)
 
   IF (ARG_MODULE_ONLY)
+    SET_TARGET_PROPERTIES(${target} PROPERTIES OUTPUT_NAME "${target}")
     # Store all components in the same directory, for easier testing.
     SET_TARGET_PROPERTIES(${target} PROPERTIES
       LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/plugin_output_directory

cmake/install_macros.cmake

@@ -260,17 +260,26 @@ FUNCTION(INSTALL_DEBUG_TARGET target)
     COMPONENT ${ARG_COMPONENT}
     OPTIONAL)
 
-  # mysqld-debug and debug/group_replication.so both need cleanup of RPATH.
-  # We could/should *generate* these files, but since it only affects two
-  # binaries, we hard-code them for simplicity.
+  # mysqld-debug and some debug plugins need to change RPATH during install.
+  # The RPATH fixup script for mysqld-debug is hard-coded.
+  # We have a template .cmake.in file for any plugin that needs cleanup.
 
   # NOTE: scripts should work for 'make install' and 'make package'.
   IF(UNIX_INSTALL_RPATH_ORIGIN_PRIV_LIBDIR)
     IF(${target} STREQUAL "mysqld")
       INSTALL(SCRIPT ${CMAKE_SOURCE_DIR}/cmake/rpath_remove.cmake)
     ENDIF()
-    IF(${target} STREQUAL "group_replication")
-      INSTALL(SCRIPT ${CMAKE_SOURCE_DIR}/cmake/rpath_remove_gr.cmake)
+    # These plugins depend, directly or indirectly, on protobuf.
+    IF(${target} STREQUAL "group_replication" OR
+        ${target} STREQUAL "telemetry_client" OR
+        ${target} STREQUAL "component_telemetry"
+        )
+      GET_TARGET_PROPERTY(output_name ${target} OUTPUT_NAME)
+      SET(plugin_so_file "${output_name}.so")
+      CONFIGURE_FILE(${CMAKE_SOURCE_DIR}/cmake/rpath_remove_plugin.cmake.in
+        ${CMAKE_BINARY_DIR}/rpath_${output_name}.cmake @ONLY)
+      INSTALL(SCRIPT ${CMAKE_BINARY_DIR}/rpath_${output_name}.cmake)
+      MESSAGE(STATUS "Changing RPATH when installing ${debug_target_location}")
     ENDIF()
   ENDIF()
 
@@ -291,7 +300,7 @@ FUNCTION(INSTALL_DEBUG_TARGET target)
       COMPONENT ${ARG_COMPONENT}
       OPTIONAL)
   ENDIF()
-ENDFUNCTION()
+ENDFUNCTION(INSTALL_DEBUG_TARGET)
 
 
 FUNCTION(INSTALL_PRIVATE_LIBRARY TARGET)

cmake/rpath_remove_gr.cmake renamed to cmake/rpath_remove_plugin.cmake.in

@@ -20,7 +20,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
 
-# Clean up RPATH for the debug verson of group_replication.so after INSTALL.
+# Clean up RPATH for the debug verson of @plugin_so_file@ after INSTALL.
 
 # See the generated cmake_install.cmake files:
 IF("x${CMAKE_INSTALL_COMPONENT}x" STREQUAL "xServerx" OR
@@ -30,11 +30,11 @@ ELSE()
   RETURN()
 ENDIF()
 
-# The debug plugin is in INSTALL_PLUGINDIR/debug/group_replication.so
+# The debug plugin is in INSTALL_PLUGINDIR/debug/@plugin_so_file@
 FOREACH(PATH
-    "lib64/mysql/plugin/debug/group_replication.so"
-    "lib/mysql/plugin/debug/group_replication.so"
-    "lib/plugin/debug/group_replication.so"
+    "lib64/mysql/plugin/debug/@plugin_so_file@"
+    "lib/mysql/plugin/debug/@plugin_so_file@"
+    "lib/plugin/debug/@plugin_so_file@"
     )
   SET(FULL_PATH "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${PATH}")
   MESSAGE(STATUS "Looking for ${FULL_PATH}")
@@ -45,7 +45,7 @@ FOREACH(PATH
 ENDFOREACH()
 
 IF(NOT DEBUG_PLUGIN)
-  MESSAGE(WARNING "Could not find debug version of group_replication.so")
+  MESSAGE(WARNING "Could not find debug version of @plugin_so_file@")
   RETURN()
 ENDIF()