Skip to content

Commit 4b0900e

Browse files
author
Tor Didriksen
committed
WL#10655 - Global notification for GR membership changes
Post-push fix clang warnings: plugin/x/src/mq/notice_configuration.h:48:8: warning: 'get_name_by_notice_type' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] Change-Id: I2d72a858801ea1c93961733d2989b376800ae7f9
1 parent 00e2aae commit 4b0900e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

plugin/x/src/mq/notice_configuration.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class Notice_configuration : public ngs::Notice_configuration_interface {
4646
}
4747

4848
bool get_name_by_notice_type(const Notice_type notice_type,
49-
std::string *out_name) const {
49+
std::string *out_name) const override {
5050
const auto &notice_name_to_type = get_map_of_notice_names();
5151

5252
for (const auto &entry : notice_name_to_type) {
@@ -60,7 +60,7 @@ class Notice_configuration : public ngs::Notice_configuration_interface {
6060
}
6161

6262
bool get_notice_type_by_name(const std::string &name,
63-
Notice_type *out_notice_type) const {
63+
Notice_type *out_notice_type) const override {
6464
const auto &notice_name_to_type = get_map_of_notice_names();
6565
const auto type = notice_name_to_type.find(name);
6666

@@ -71,11 +71,12 @@ class Notice_configuration : public ngs::Notice_configuration_interface {
7171
return true;
7272
}
7373

74-
bool is_notice_enabled(const Notice_type notice_type) const {
74+
bool is_notice_enabled(const Notice_type notice_type) const override {
7575
return m_notices[static_cast<int>(notice_type)];
7676
}
7777

78-
void set_notice(const Notice_type notice_type, const bool should_be_enabled) {
78+
void set_notice(const Notice_type notice_type,
79+
const bool should_be_enabled) override {
7980
DBUG_ASSERT(notice_type != Notice_type::k_last_element);
8081
m_notices[static_cast<int>(notice_type)] = should_be_enabled;
8182

0 commit comments

Comments
 (0)