Bug#33307573 unused variables warning on windows

Issue
=====

clang on windows reports unused variables.

Change
======

- ifdef variables properly.

RB: 26947

Author: weigon

router/src/harness/src/loader.cc

@@ -86,7 +86,9 @@ using namespace std::chrono_literals;
 static std::atomic<size_t> num_of_non_ready_services{0};
 
 static const char kLogReopenServiceName[] = "log_reopen";
+#if defined(USE_POSIX_SIGNALS)
 static const char kSignalHandlerServiceName[] = "signal_handler";
+#endif
 
 /**
  * @defgroup Loader Plugin loader

router/src/harness/tests/test_net_ts_impl_file.cc

@@ -32,6 +32,10 @@
  * @test closing an invalid file-descriptor should result in bad_file_desc.
  */
 TEST(NetTS_impl_file, close_invalid_handle) {
+#if !defined(_WIN32)
+  // TODO(jkneschk) investigate why windows returns 'true' in this case
+  // according to the docs it shouldn't
+
   const auto expected_ec =
 #ifdef _WIN32
       std::error_code(ERROR_INVALID_HANDLE, std::system_category())
@@ -40,9 +44,6 @@ TEST(NetTS_impl_file, close_invalid_handle) {
 #endif
       ;
 
-#if !defined(_WIN32)
-  // TODO(jkneschk) investigate why windows returns 'true' in this case
-  // according to the docs it shouldn't
   EXPECT_EQ(net::impl::file::close(net::impl::file::kInvalidHandle),
             stdx::make_unexpected(expected_ec));
 #endif