Bug#25469190: MYSQLPUMP SHOULD EXCLUDE REPLICATION

              REPOSITORY METADATA TABLES

Description : Replication meta data tables such as
mysql.slave_master_info and mysql.slave_relay_log_info
gets backed up when MYSQLPUMP is executed.

Analysis: The above mentioned replication tables should be
excluded from backups because they are not a logical part of
data. These tables contain replication channel meta data
that will leave the replication meta data in an invalid
state after the restoration of the dump.

Fix: Both the tables are excluded from MYSQLPUMP.

Author: Arun Kuruvila

client/dump/mysqldump_tool_chain_maker_options.cc

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+  Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -152,6 +152,10 @@ void Mysqldump_tool_chain_maker_options::process_positional_options(
       "mysql", "general_log"));
     m_object_filter.m_tables_excluded.push_back(std::make_pair(
       "mysql", "slow_log"));
+    m_object_filter.m_tables_excluded.push_back(std::make_pair(
+      "mysql", "slave_master_info"));
+    m_object_filter.m_tables_excluded.push_back(std::make_pair(
+      "mysql", "slave_relay_log_info"));
     /*
       We filter out all the tables which store account and privilge
       information. ex: mysql.user, mysql.db, mysql.tables_priv,

mysql-test/r/mysqlpump.result

@@ -432,3 +432,27 @@ DROP DATABASE db1;
 DROP DATABASE db2;
 DROP DATABASE db3;
 DROP DATABASE db1_1gb;
+SHOW VARIABLES LIKE "master_info_repository";
+Variable_name	Value
+master_info_repository	FILE
+SHOW VARIABLES LIKE "relay_log_info_repository";
+Variable_name	Value
+relay_log_info_repository	FILE
+SET GLOBAL master_info_repository= 'TABLE';
+SET GLOBAL relay_log_info_repository= 'TABLE';
+SHOW VARIABLES LIKE "master_info_repository";
+Variable_name	Value
+master_info_repository	TABLE
+SHOW VARIABLES LIKE "relay_log_info_repository";
+Variable_name	Value
+relay_log_info_repository	TABLE
+Pattern "CREATE TABLE `mysql`.`slave_master_info`" not found
+Pattern "CREATE TABLE `mysql`.`slave_relay_log_info`" not found
+SET GLOBAL master_info_repository= 'FILE';
+SET GLOBAL relay_log_info_repository= 'FILE';
+SHOW VARIABLES LIKE "master_info_repository";
+Variable_name	Value
+master_info_repository	FILE
+SHOW VARIABLES LIKE "relay_log_info_repository";
+Variable_name	Value
+relay_log_info_repository	FILE

mysql-test/t/mysqlpump.test

@@ -124,5 +124,40 @@ DROP DATABASE db1_1gb;
 --exec $MYSQL_PUMP --version 2>&1 > $MYSQLTEST_VARDIR/tmp/output_file.txt
 --remove_file $MYSQLTEST_VARDIR/tmp/output_file.txt
 
+#
+# Bug #25469190: MYSQLPUMP SHOULD EXCLUDE REPLICATION
+#                REPOSITORY METADATA TABLES
+#
+
+SHOW VARIABLES LIKE "master_info_repository";
+SHOW VARIABLES LIKE "relay_log_info_repository";
+
+SET GLOBAL master_info_repository= 'TABLE';
+SET GLOBAL relay_log_info_repository= 'TABLE';
+
+SHOW VARIABLES LIKE "master_info_repository";
+SHOW VARIABLES LIKE "relay_log_info_repository";
+
+--exec $MYSQL_PUMP --include-databases=mysql > $MYSQLTEST_VARDIR/tmp/bug25469190.sql
+
+# Search for mysql.slave_master_info in the dump file
+--let SEARCH_FILE= $MYSQLTEST_VARDIR/tmp/bug25469190.sql
+--let SEARCH_PATTERN= CREATE TABLE `mysql`.`slave_master_info`
+--source include/search_pattern.inc
+
+# Search for mysql.slave_relay_log_info in the dump file
+--let SEARCH_FILE= $MYSQLTEST_VARDIR/tmp/bug25469190.sql
+--let SEARCH_PATTERN= CREATE TABLE `mysql`.`slave_relay_log_info`
+--source include/search_pattern.inc
+
+SET GLOBAL master_info_repository= 'FILE';
+SET GLOBAL relay_log_info_repository= 'FILE';
+
+SHOW VARIABLES LIKE "master_info_repository";
+SHOW VARIABLES LIKE "relay_log_info_repository";
+
+# Cleanup
+--remove_file $SEARCH_FILE
+
 
 # END OF TEST