Bug#36444257: `false' in operator at sql/sql_executor.cc

A const item that is part of group by and not found in select list is not
added as a hidden item to the field's list post the fix for Bug#34951115.
This is not taken into consideration while checking for replacements for
expressions involving ROLLUP operation during temp table creation. So
server fails a check.
Fix is to check if the item that is not found in the field's list
is a const item. If so, the same item will be used as a replacement.

Change-Id: Ifca0618ef42930018def7a787f8c9aa3cd7d8be8

Author: Chaithra Gopalareddy

mysql-test/r/olap.result

@@ -2365,3 +2365,10 @@ EXECUTE ps;
 x
 DROP PREPARE ps;
 DROP TABLE t;
+#
+# Bug#36444257: `false' in operator at sql/sql_executor.cc
+#
+CREATE TABLE t1(f1 INTEGER);
+SELECT SUM(TAN(0)) OVER() FROM t1 GROUP BY TAN(0) WITH ROLLUP;
+SUM(TAN(0)) OVER()
+DROP TABLE t1;

mysql-test/t/olap.test

@@ -1303,3 +1303,11 @@ EXECUTE ps;
 EXECUTE ps;
 DROP PREPARE ps;
 DROP TABLE t;
+
+--echo #
+--echo # Bug#36444257: `false' in operator at sql/sql_executor.cc
+--echo #
+
+CREATE TABLE t1(f1 INTEGER);
+SELECT SUM(TAN(0)) OVER() FROM t1 GROUP BY TAN(0) WITH ROLLUP;
+DROP TABLE t1;

sql/sql_executor.cc

@@ -4229,6 +4229,12 @@ static bool replace_embedded_rollup_references_with_tmp_fields(
         return {ReplaceResult::REPLACE, item_field};
       }
     }
+    // A const item that is part of group by and not found in
+    // select list will not be found in "fields" (It's not added
+    // as a hidden item).
+    if (unwrap_rollup_group(sub_item)->const_item()) {
+      return {ReplaceResult::REPLACE, sub_item};
+    }
     assert(false);
     return {ReplaceResult::ERROR, nullptr};
   };