Skip to content

Commit 58dc14f

Browse files
author
Shishir Jaiswal
committed
Merge branch 'mysql-5.7' into mysql-8.0
2 parents d53f340 + d72e199 commit 58dc14f

File tree

5 files changed

+62
-60
lines changed

5 files changed

+62
-60
lines changed

mysql-test/collections/disabled-asan.list

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ main.dd_bootstrap : Bug#24421481 2016-08-08 edahl
55
binlog.binlog_check_flush_log_assertion : Bug#22732184 2017-03-10 edahl
66
innodb.virtual_basic : Bug#25431979 2017-03-27 edahl
77
rpl.rpl_json : Bug#25873029 2017-05-03 edahl
8+
main.mysqlpump_partial_bkp : Bug#26199978 2017-11-13 shisjais

mysql-test/r/mysqlpump_extended.result

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -368,23 +368,3 @@ INSERT INTO t1 VALUES (x) utf8mb4 utf8mb4_0900_ai_ci utf8mb4_0900_ai_ci
368368
DROP DATABASE db1_extended;
369369
DROP USER u1@localhost;
370370
# test for compress-output
371-
#
372-
# Bug#26199978 - WRONG ERROR MESSAGE FOR PARTIAL BACKUPS WITH GTID_MODE = ON
373-
#
374-
# Test 1: Taking backup when --set-gtid-purged is passed as ON
375-
CREATE DATABASE bug26199978;
376-
DROP DATABASE bug26199978;
377-
# Backup file should contain "SET @@GLOBAL.GTID_PURGED=.* '.*'"
378-
Pattern "SET @@GLOBAL.GTID_PURGED=.* '.*'" found
379-
# Test 2: Taking backup when --set-gtid-purged is pased as OFF
380-
CREATE DATABASE bug26199978;
381-
DROP DATABASE bug26199978;
382-
# Backup file should NOT contain "SET @@GLOBAL.GTID_PURGED=.* '.*'"
383-
Matching lines are:
384-
None
385-
Occurrences of 'SET @@GLOBAL.GTID_PURGED=.* '.*'' in the input file: 0
386-
# Test 3: Taking backup when --set-gtid-purged is passed as AUTO. Should error out
387-
# asking to pass --set-gtid-purged=[ON|OFF]
388-
CREATE DATABASE bug26199978;
389-
DROP DATABASE bug26199978;
390-
# Cleanup
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
#
2+
# Bug#26199978 - WRONG ERROR MESSAGE FOR PARTIAL BACKUPS WITH GTID_MODE = ON
3+
#
4+
# Test 1: Taking backup when --set-gtid-purged is passed as ON
5+
CREATE DATABASE bug26199978;
6+
DROP DATABASE bug26199978;
7+
# Backup file should contain "SET @@GLOBAL.GTID_PURGED=.* '.*'"
8+
Pattern "SET @@GLOBAL.GTID_PURGED=.* '.*'" found
9+
# Test 2: Taking backup when --set-gtid-purged is pased as OFF
10+
CREATE DATABASE bug26199978;
11+
DROP DATABASE bug26199978;
12+
# Backup file should NOT contain "SET @@GLOBAL.GTID_PURGED=.* '.*'"
13+
Matching lines are:
14+
None
15+
Occurrences of 'SET @@GLOBAL.GTID_PURGED=.* '.*'' in the input file: 0
16+
# Test 3: Taking backup when --set-gtid-purged is passed as AUTO. Should error out
17+
# asking to pass --set-gtid-purged=[ON|OFF]
18+
CREATE DATABASE bug26199978;
19+
DROP DATABASE bug26199978;
20+
# Cleanup

mysql-test/t/mysqlpump_extended.test

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -426,43 +426,3 @@ DROP USER u1@localhost;
426426
#cleanup
427427
--remove_file $MYSQLTEST_VARDIR/tmp/db1_extended.zlib
428428
--remove_file $MYSQLTEST_VARDIR/tmp/db1_extended.lz4
429-
430-
-- echo #
431-
-- echo # Bug#26199978 - WRONG ERROR MESSAGE FOR PARTIAL BACKUPS WITH GTID_MODE = ON
432-
-- echo #
433-
434-
--exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
435-
--shutdown_server 10
436-
--source include/wait_until_disconnected.inc
437-
--enable_reconnect
438-
--exec echo "restart: --enforce-gtid-consistency=ON --gtid-mode=ON" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
439-
--source include/wait_until_connected_again.inc
440-
441-
let SEARCH_FILE=$MYSQLTEST_VARDIR/tmp/bug26199978_gtid-purged_ON.sql;
442-
let SEARCH_PATTERN=SET @@GLOBAL.GTID_PURGED=.* '.*';
443-
let GREP_FILE=$MYSQLTEST_VARDIR/tmp/bug26199978_gtid-purged_OFF.sql;
444-
let GREP_PATTERN=$SEARCH_PATTERN;
445-
446-
--echo # Test 1: Taking backup when --set-gtid-purged is passed as ON
447-
CREATE DATABASE bug26199978;
448-
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=ON > $SEARCH_FILE
449-
DROP DATABASE bug26199978;
450-
--echo # Backup file should contain "$SEARCH_PATTERN"
451-
--source include/search_pattern.inc
452-
453-
--echo # Test 2: Taking backup when --set-gtid-purged is pased as OFF
454-
CREATE DATABASE bug26199978;
455-
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=OFF > $GREP_FILE
456-
DROP DATABASE bug26199978;
457-
--echo # Backup file should NOT contain "$GREP_PATTERN"
458-
--source include/grep_pattern.inc
459-
460-
--echo # Test 3: Taking backup when --set-gtid-purged is passed as AUTO. Should error out
461-
--echo # asking to pass --set-gtid-purged=[ON|OFF]
462-
CREATE DATABASE bug26199978;
463-
--error 1
464-
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=AUTO > $MYSQLTEST_VARDIR/tmp/bug26199978_auto.sql
465-
DROP DATABASE bug26199978;
466-
467-
--echo # Cleanup
468-
--remove_files_wildcard $MYSQLTEST_VARDIR/tmp bug26199978_*.sql
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
--source include/not_valgrind.inc
2+
3+
--echo #
4+
--echo # Bug#26199978 - WRONG ERROR MESSAGE FOR PARTIAL BACKUPS WITH GTID_MODE = ON
5+
--echo #
6+
7+
--exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
8+
--shutdown_server 10
9+
--source include/wait_until_disconnected.inc
10+
--enable_reconnect
11+
--exec echo "restart: --enforce-gtid-consistency=ON --gtid-mode=ON" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
12+
--source include/wait_until_connected_again.inc
13+
14+
let SEARCH_FILE=$MYSQLTEST_VARDIR/tmp/bug26199978_gtid-purged_ON.sql;
15+
let SEARCH_PATTERN=SET @@GLOBAL.GTID_PURGED=.* '.*';
16+
let GREP_FILE=$MYSQLTEST_VARDIR/tmp/bug26199978_gtid-purged_OFF.sql;
17+
let GREP_PATTERN=$SEARCH_PATTERN;
18+
19+
--echo # Test 1: Taking backup when --set-gtid-purged is passed as ON
20+
CREATE DATABASE bug26199978;
21+
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=ON > $SEARCH_FILE
22+
DROP DATABASE bug26199978;
23+
--echo # Backup file should contain "$SEARCH_PATTERN"
24+
--source include/search_pattern.inc
25+
26+
--echo # Test 2: Taking backup when --set-gtid-purged is pased as OFF
27+
CREATE DATABASE bug26199978;
28+
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=OFF > $GREP_FILE
29+
DROP DATABASE bug26199978;
30+
--echo # Backup file should NOT contain "$GREP_PATTERN"
31+
--source include/grep_pattern.inc
32+
33+
--echo # Test 3: Taking backup when --set-gtid-purged is passed as AUTO. Should error out
34+
--echo # asking to pass --set-gtid-purged=[ON|OFF]
35+
CREATE DATABASE bug26199978;
36+
--error 1
37+
--exec $MYSQL_PUMP --databases bug26199978 --set-gtid-purged=AUTO > $MYSQLTEST_VARDIR/tmp/bug26199978_auto.sql
38+
DROP DATABASE bug26199978;
39+
40+
--echo # Cleanup
41+
--remove_files_wildcard $MYSQLTEST_VARDIR/tmp bug26199978_*.sql

0 commit comments

Comments
 (0)