Bug#34992370 IndexStatBg seizeTxHandle() failure stops automated index stat updates

arnabray21 · arnabray21 · commit 62f51bbbbdda · 2023-02-27T18:53:34.000+05:30
Problem:
--------

If the seize of a TxHandle fails, then the IndexStat calculation
monitoring fiber exits, so that there can be no more automated index
stat updates without a node failure.

Fix:
----

Wait and eventually retry the TxHandle seize instead of exiting.

Change-Id: I1e15e1d7176de35481823dbfc644da078787c665
diff --git a/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp b/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp
@@ -17138,7 +17138,7 @@ Dbdict::indexStatBg_process(Signal* signal)
     TxHandlePtr tx_ptr;
     if (!seizeTxHandle(tx_ptr)) {
       jam();
-      return; // wait for one
+      break; // wait for one
     }
     Callback c = {
       safe_cast(&Dbdict::indexStatBg_fromBeginTrans),

Original file line number	Diff line number	Diff line change
`@@ -17138,7 +17138,7 @@ Dbdict::indexStatBg_process(Signal* signal)`
`17138`	`17138`	`TxHandlePtr tx_ptr;`
`17139`	`17139`	`if (!seizeTxHandle(tx_ptr)) {`
`17140`	`17140`	`jam();`
`17141`		`- return; // wait for one`
	`17141`	`+ break; // wait for one`
`17142`	`17142`	`}`
`17143`	`17143`	`Callback c = {`
`17144`	`17144`	`safe_cast(&Dbdict::indexStatBg_fromBeginTrans),`