Bug#35318781 parameter_count_available has the wrong value

Decoding StmtExecute with the parameter-count-available
flag set fails.

This is only noticed if the tracer is enabled at build-time
as the StmtExecute message isn't decoded by default.

The routertest_integration_routing_direct fails due to this if the
tracer is enabled.

Change
------

- fixed values of the StmtExecute flags which were off-by-one

Change-Id: Ib31d01150ef3e925218af7834dddb720be43c2fa

Author: weigon

router/src/mysql_protocol/include/mysqlrouter/classic_protocol_constants.h

@@ -209,17 +209,16 @@ constexpr value_type session_state_changed{1 << pos::session_state_changed};
 namespace cursor {
 namespace pos {
 using value_type = uint8_t;
-constexpr value_type no_cursor{0};
-constexpr value_type read_only{1};
-constexpr value_type for_update{2};
-constexpr value_type scrollable{3};
-constexpr value_type param_count_available{4};
+constexpr value_type read_only{0};
+constexpr value_type for_update{1};
+constexpr value_type scrollable{2};
+constexpr value_type param_count_available{3};
 
 constexpr value_type _bitset_size{param_count_available + 1};
 }  // namespace pos
 using value_type = std::bitset<pos::_bitset_size>;
 
-constexpr value_type no_cursor{1 << pos::no_cursor};
+constexpr value_type no_cursor{0};
 constexpr value_type read_only{1 << pos::read_only};
 constexpr value_type for_update{1 << pos::for_update};
 constexpr value_type scrollable{1 << pos::scrollable};

router/src/mysql_protocol/tests/test_classic_protocol_message.cc

@@ -1289,7 +1289,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
         {"cap_query_attributes_one_param",
          {
              1,     // stmt-id
-             0x10,  // flags
+             0x08,  // flags
              1,     // iteration_count
              true,  // new-params bound
              {{classic_protocol::field_type::String, "abc"}},  // types
@@ -1300,7 +1300,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
              // serialized
              0x17,                    // cmd
              0x01, 0x00, 0x00, 0x00,  // stmt-id
-             0x10,                    // flags: param-count-available
+             0x08,                    // flags: param-count-available
              0x01, 0x00, 0x00, 0x00,  // iteration-count
              0x01,                    // param-count
              0x00,                    // null-bitmap
@@ -1312,7 +1312,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
         {"cap_query_attributes_null_param",
          {
              1,     // stmt-id
-             0x10,  // flags
+             0x08,  // flags
              1,     // iteration_count
              true,  // new-params bound
              {{classic_protocol::field_type::String, "abc"}},  // types
@@ -1323,7 +1323,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
              // serialized
              0x17,                    // cmd
              0x01, 0x00, 0x00, 0x00,  // stmt-id
-             0x10,                    // flags: param-count-available
+             0x08,                    // flags: param-count-available
              0x01, 0x00, 0x00, 0x00,  // iteration-count
              0x01,                    // param-count
              0x01,                    // null-bitmap: data[0]: NULL
@@ -1334,7 +1334,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
         {"cap_query_attributes_8_params",
          {
              1,     // stmt-id
-             0x10,  // flags
+             0x08,  // flags
              1,     // iteration_count
              true,  // new-params bound
              {
@@ -1361,7 +1361,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
              // serialized
              0x17,                          // cmd
              0x01, 0x00, 0x00, 0x00,        // stmt-id
-             0x10,                          // flags: param-count-available
+             0x08,                          // flags: param-count-available
              0x01, 0x00, 0x00, 0x00,        // iteration-count
              0x08,                          // param-count
              0x00,                          // null-bitmap
@@ -1396,7 +1396,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
         {"cap_query_attributes_9_params",
          {
              1,     // stmt-id
-             0x10,  // flags
+             0x08,  // flags
              1,     // iteration_count
              true,  // new-params bound
              {
@@ -1425,7 +1425,7 @@ const CodecParam<classic_protocol::message::client::StmtExecute>
              // serialized
              0x17,                    // cmd
              0x01, 0x00, 0x00, 0x00,  // stmt-id
-             0x10,                    // flags: param-count-available
+             0x08,                    // flags: param-count-available
              0x01, 0x00, 0x00, 0x00,  // iteration-count
              0x09,                    // param-count
              0x40, 0x00,              // null-bitmap: data[6]: NULL