Skip to content

Commit 7874d7f

Browse files
author
Hemant Dangi
committed
WL#14595: Refactor GR recovery to do not use View_change_log_event
- Deprecate warning when using group_replication_view_change_uuid variables. Change-Id: I361393246d12ac899c773d19c641721d5bdd50ec
1 parent 6b94984 commit 7874d7f

14 files changed

+270
-0
lines changed

‎mysql-test/suite/group_replication/r/gr_concurrent_ticket_pop_with_channel.result

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ Note #### Storing MySQL user name or password information in the connection meta
99
[connection server1]
1010
include/save_sysvars.inc [ "GLOBAL.group_replication_view_change_uuid" ]
1111
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
12+
Warnings:
13+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1214
include/start_and_bootstrap_group_replication.inc
15+
Warnings:
16+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1317
CHANGE REPLICATION SOURCE TO SOURCE_HOST='127.0.0.1', SOURCE_USER='root', SOURCE_AUTO_POSITION=1, SOURCE_PORT=SERVER_3_PORT FOR CHANNEL 'ch1';
1418
Warnings:
1519
Note 1759 Sending passwords in plain text without SSL/TLS is extremely insecure.
@@ -37,8 +41,12 @@ SET DEBUG_SYNC= "now WAIT_FOR signal.ordered_commit_waiting";
3741
[connection server2]
3842
include/save_sysvars.inc [ "GLOBAL.group_replication_view_change_uuid" ]
3943
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
44+
Warnings:
45+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
4046
SET GLOBAL group_replication_group_name= "GROUP_REPLICATION_GROUP_NAME";
4147
START GROUP_REPLICATION;
48+
Warnings:
49+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
4250
[connection server1]
4351
include/assert.inc ['There is a worker whose stage reports it is waiting on a ticket']
4452
#
@@ -53,8 +61,12 @@ SET DEBUG_SYNC= "now WAIT_FOR signal.end_of_ticket_waiting";
5361
[connection server4]
5462
include/save_sysvars.inc [ "GLOBAL.group_replication_view_change_uuid" ]
5563
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
64+
Warnings:
65+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
5666
SET GLOBAL group_replication_group_name= "GROUP_REPLICATION_GROUP_NAME";
5767
START GROUP_REPLICATION;
68+
Warnings:
69+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
5870
[connection server1]
5971
#
6072
# 6. Unblock the stuck ticket
@@ -71,10 +83,16 @@ include/stop_slave.inc
7183
CHANGE REPLICATION SOURCE TO SOURCE_AUTO_POSITION=0 FOR CHANNEL "ch1";
7284
include/stop_group_replication.inc
7385
include/restore_sysvars.inc
86+
Warnings:
87+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
7488
[connection server2]
7589
include/stop_group_replication.inc
7690
include/restore_sysvars.inc
91+
Warnings:
92+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
7793
[connection server4]
7894
include/stop_group_replication.inc
7995
include/restore_sysvars.inc
96+
Warnings:
97+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
8098
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_persist_variables.result

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ SET PERSIST group_replication_tls_source = @@GLOBAL.group_replication_tls_source
8585
SET PERSIST group_replication_transaction_size_limit = @@GLOBAL.group_replication_transaction_size_limit;
8686
SET PERSIST group_replication_unreachable_majority_timeout = @@GLOBAL.group_replication_unreachable_majority_timeout;
8787
SET PERSIST group_replication_view_change_uuid = @@GLOBAL.group_replication_view_change_uuid;
88+
Warnings:
89+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
8890

8991
include/assert.inc ['Expect 60 persisted variables.']
9092

‎mysql-test/suite/group_replication/r/gr_show_global_and_session_variables.result

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ SET @@SESSION.group_replication_paxos_single_leader= 1;
101101
ERROR HY000: Variable 'group_replication_paxos_single_leader' is a GLOBAL variable and should be set with SET GLOBAL
102102
Warnings:
103103
Warning 1681 'group_replication_recovery_complete_at' is deprecated and will be removed in a future release.
104+
Warnings:
105+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
104106

105107
# Test#3: Verify group replication related variables at SESSION scope.
106108
SET @@SESSION.group_replication_consistency= "EVENTUAL";
@@ -110,6 +112,7 @@ SET @@SESSION.group_replication_consistency= DEFAULT;
110112
include/start_group_replication.inc
111113
Warnings:
112114
Warning 1681 'group_replication_recovery_complete_at' is deprecated and will be removed in a future release.
115+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
113116
SET GLOBAL group_replication_recovery_ssl_crl= 'crl-client-revoked.crl';
114117
SET GLOBAL group_replication_recovery_tls_ciphersuites= "";
115118
include/assert.inc [Verify GLOBAL value of group_replication_allow_local_lower_version_join]
@@ -294,4 +297,6 @@ include/assert.inc [Verify SESSION value of group_replication_paxos_single_leade
294297
include/stop_group_replication.inc
295298
Warnings:
296299
Warning 1681 'group_replication_recovery_complete_at' is deprecated and will be removed in a future release.
300+
Warnings:
301+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
297302
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_variables_default_values.result

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,6 @@ include/assert.inc [Default group_replication_paxos_single_leader is 0]
139139
#
140140
Warnings:
141141
Warning 1681 'group_replication_recovery_complete_at' is deprecated and will be removed in a future release.
142+
Warnings:
143+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
142144
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_variables_privileges.result

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,8 @@ SET GLOBAL group_replication_tls_source = @@GLOBAL.group_replication_tls_source;
227227
SET GLOBAL group_replication_transaction_size_limit = @@GLOBAL.group_replication_transaction_size_limit;
228228
SET GLOBAL group_replication_unreachable_majority_timeout = @@GLOBAL.group_replication_unreachable_majority_timeout;
229229
SET GLOBAL group_replication_view_change_uuid = @@GLOBAL.group_replication_view_change_uuid;
230+
Warnings:
231+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
230232

231233
############################################################
232234
# 4. Grant GROUP_REPLICATION_ADMIN and verify setting

‎mysql-test/suite/group_replication/r/gr_view_change_uuid.result

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ SET sql_log_bin = 1;
2121
[connection server1]
2222
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
2323
SET GLOBAL group_replication_view_change_uuid = "c0dec0de-c0de-c0de-c0de-c0dec0dec0de";
24+
Warnings:
25+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
2426
include/start_and_bootstrap_group_replication.inc
27+
Warnings:
28+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
2529
include/assert.inc [GTID_EXECUTED must have one transaction of view change]
2630
include/show_binlog_events.inc
2731
Log_name Pos Event_type Server_id End_log_pos Info
@@ -35,7 +39,11 @@ server-binary-log.000001 # Query # # COMMIT
3539
[connection server2]
3640
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
3741
SET GLOBAL group_replication_view_change_uuid = "c0dec0de-c0de-c0de-c0de-c0dec0dec0de";
42+
Warnings:
43+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
3844
include/start_group_replication.inc
45+
Warnings:
46+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
3947
include/assert.inc [GTID_EXECUTED must have two transactions of view changes]
4048
include/show_binlog_events.inc
4149
Log_name Pos Event_type Server_id End_log_pos Info
@@ -66,7 +74,11 @@ server-binary-log.000001 # Query # # COMMIT
6674
[connection server3]
6775
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
6876
SET GLOBAL group_replication_view_change_uuid = "c0dec0de-c0de-c0de-c0de-c0dec0dec0de";
77+
Warnings:
78+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
6979
include/start_group_replication.inc
80+
Warnings:
81+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
7082
include/assert.inc [GTID_EXECUTED must have three transactions of view changes]
7183
include/show_binlog_events.inc
7284
Log_name Pos Event_type Server_id End_log_pos Info
@@ -154,6 +166,8 @@ server-binary-log.000001 # Query # # COMMIT
154166
# 9. Start server 2 and assert it has 4 transactions
155167
[connection server2]
156168
include/start_group_replication.inc
169+
Warnings:
170+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
157171
include/assert.inc [GTID_EXECUTED must have four transactions of view changes]
158172
include/show_binlog_events.inc
159173
Log_name Pos Event_type Server_id End_log_pos Info
@@ -195,6 +209,8 @@ server-binary-log.000001 # Query # # COMMIT
195209
# 11. Start server 3 and assert it has 5 transactions
196210
[connection server3]
197211
include/start_group_replication.inc
212+
Warnings:
213+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
198214
include/assert.inc [GTID_EXECUTED must have five transactions of view changes]
199215
include/show_binlog_events.inc
200216
Log_name Pos Event_type Server_id End_log_pos Info
@@ -267,17 +283,25 @@ include/gtid_utils_end.inc
267283
SET sql_log_bin = 1;
268284
include/stop_group_replication.inc
269285
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
286+
Warnings:
287+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
270288
SET GLOBAL group_replication_view_change_uuid = "AUTOMATIC";
289+
Warnings:
290+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
271291
[connection server2]
272292
SET sql_log_bin = 0;
273293
include/gtid_utils_end.inc
274294
SET sql_log_bin = 1;
275295
include/stop_group_replication.inc
276296
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
297+
Warnings:
298+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
277299
[connection server3]
278300
SET sql_log_bin = 0;
279301
include/gtid_utils_end.inc
280302
SET sql_log_bin = 1;
281303
include/stop_group_replication.inc
282304
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
305+
Warnings:
306+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
283307
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_view_change_uuid_check_configuration.result

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,15 @@ include/assert_grep.inc [group_replication_view_change_uuid shall be diferent fr
4242
# 4. We can't set group_replication_group_name to same uuid
4343
# configured on group_replication_view_change_uuid
4444
SET GLOBAL group_replication_view_change_uuid = "9f46e042-98a0-439d-a8fb-7130670ca49b";
45+
Warnings:
46+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
4547
SET GLOBAL group_replication_group_name = "9f46e042-98a0-439d-a8fb-7130670ca49b";
4648
ERROR HY000: Variable 'group_replication_group_name' cannot be set to the value of '9f46e042-98a0-439d-a8fb-7130670ca49b'. The value is the same as group_replication_view_change_uuid. Please change group_replication_view_change_uuid to AUTOMATIC
4749
####################################################################
4850
# 5. Cleanup
4951
RESET PERSIST;
5052
SET GLOBAL group_replication_view_change_uuid = VIEW_CHANGE_UUID;
5153
Warnings:
54+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
55+
Warnings:
5256
Warning 3615 Variable group_replication_ip_allowlist does not exist in persisted config file

‎mysql-test/suite/group_replication/r/gr_view_change_uuid_deprecation.result

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
include/group_replication.inc
2+
Warnings:
3+
Note #### Sending passwords in plain text without SSL/TLS is extremely insecure.
4+
Note #### Storing MySQL user name or password information in the connection metadata repository is not secure and is therefore not recommended. Please consider using the USER and PASSWORD connection options for START REPLICA; see the 'START REPLICA Syntax' in the MySQL Manual for more information.
5+
[connection server1]
6+
7+
############################################################
8+
# 1. Set group_replication_view_change_uuid.
9+
# A deprecation warning is thrown on the client session.
10+
[connection server1]
11+
include/save_sysvars.inc [ "GLOBAL.group_replication_view_change_uuid" ]
12+
SET @@GLOBAL.group_replication_view_change_uuid= "AUTOMATIC";
13+
Warnings:
14+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
15+
16+
############################################################
17+
# 2. Set group_replication_view_change_uuid to some GTID.
18+
# A deprecation warning is thrown on the client session.
19+
[connection server1]
20+
SET @@GLOBAL.group_replication_view_change_uuid= "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
21+
Warnings:
22+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
23+
24+
############################################################
25+
# 3. Start Group Replication from client session.
26+
# A deprecation warning is thrown on the client session because
27+
# group_replication_view_change_uuid is not the default one.
28+
[connection server1]
29+
include/start_and_bootstrap_group_replication.inc
30+
Warnings:
31+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
32+
33+
############################################################
34+
# 4. Start Group Replication on server start.
35+
# A deprecation warning is logged on the error log because
36+
# group_replication_view_change_uuid is not the default one.
37+
[connection server1]
38+
# restart:--group_replication_group_name=GROUP_REPLICATION_GROUP_NAME --group_replication_local_address=GROUP_REPLICATION_LOCAL_ADDRESS --group_replication_group_seeds=GROUP_REPLICATION_GROUP_SEEDS --group_replication_bootstrap_group=1 --group_replication_start_on_boot=1 --group_replication_view_change_uuid=aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa
39+
include/rpl_reconnect.inc
40+
include/gr_wait_for_member_state.inc
41+
42+
############################################################
43+
# 5. Cleanup.
44+
[connection server1]
45+
include/stop_group_replication.inc
46+
include/restore_sysvars.inc
47+
Warnings:
48+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
49+
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_view_change_uuid_equal_all_members.result

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ Note #### Storing MySQL user name or password information in the connection meta
1111
# 2. Bootstrap group with VIEW_CHANGE_UUID
1212
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
1313
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
14+
Warnings:
15+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1416
include/start_and_bootstrap_group_replication.inc
17+
Warnings:
18+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1519

1620
############################################################
1721
# 3. To change view_change_uuid group replication shall be
@@ -28,6 +32,8 @@ call mtr.add_suppression(".*The member is configured with a group_replication_vi
2832
SET SESSION sql_log_bin=1;
2933
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
3034
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaab";
35+
Warnings:
36+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
3137
SET GLOBAL group_replication_group_name = "GROUP_REPLICATION_GROUP_NAME";
3238
START GROUP_REPLICATION;
3339
ERROR HY000: The server is not configured properly to be an active member of the group. Please see more details on error log.
@@ -37,7 +43,11 @@ include/assert_grep.inc [group_replication_view_change_uuid from joiner differen
3743
# 5. Server 2 configured with view_change_uuid of group
3844
# can join
3945
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
46+
Warnings:
47+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
4048
include/start_group_replication.inc
49+
Warnings:
50+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
4151

4252
############################################################
4353
# 6. Confirm both server have same GTID.EXECUTED from all
@@ -50,7 +60,11 @@ include/assert.inc [GTID_EXECUTED must only contain view changes]
5060
# 7. Cleanup
5161
include/stop_group_replication.inc
5262
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
63+
Warnings:
64+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
5365
[connection server2]
5466
include/stop_group_replication.inc
5567
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
68+
Warnings:
69+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
5670
include/group_replication_end.inc

‎mysql-test/suite/group_replication/r/gr_view_change_uuid_recompute_intervals.result

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,19 @@ Note #### Storing MySQL user name or password information in the connection meta
99
# change uuid configured with an valid uuid
1010
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
1111
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
12+
Warnings:
13+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1214
include/start_and_bootstrap_group_replication.inc
15+
Warnings:
16+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1317
[connection server2]
1418
SET @group_replication_view_change_uuid_save= @@GLOBAL.group_replication_view_change_uuid;
1519
SET GLOBAL group_replication_view_change_uuid = "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa";
20+
Warnings:
21+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1622
include/start_group_replication.inc
23+
Warnings:
24+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
1725

1826
############################################################
1927
# 2. Create a table on server 1 that will add one
@@ -36,6 +44,8 @@ include/stop_group_replication.inc
3644
include/assert.inc [GTID_EXECUTED must contain GTID_EXECUTED 2 transactions]
3745
include/assert.inc [GTID_EXECUTED must contain GTID_EXECUTED 2 view changes]
3846
include/start_group_replication.inc
47+
Warnings:
48+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
3949

4050
############################################################
4151
# 5. Insert data into table on server 2 that will add one
@@ -63,6 +73,8 @@ SET GTID_NEXT= 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa:4';;
6373
INSERT INTO t1 VALUES (2);
6474
[connection server2]
6575
include/start_group_replication.inc
76+
Warnings:
77+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
6678

6779
############################################################
6880
# 8. Assert the intervals were not used, the new view
@@ -80,7 +92,11 @@ SET GTID_NEXT= 'AUTOMATIC';
8092
DROP TABLE t1;
8193
include/stop_group_replication.inc
8294
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
95+
Warnings:
96+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
8397
[connection server2]
8498
include/stop_group_replication.inc
8599
SET @@GLOBAL.group_replication_view_change_uuid= @group_replication_view_change_uuid_save;
100+
Warnings:
101+
Warning 1681 'group_replication_view_change_uuid' is deprecated and will be removed in a future release.
86102
include/group_replication_end.inc

0 commit comments

Comments
 (0)